firebug errors with "updatefile is not defined"
After installing livecoverage and visiting "liveupdate/live" I receive this error. It does not seem to affect subsequent calls.
var updatefile is being placed via inline js, which can cause problems. A better method is to drupal_add_js('setting', $settings) after you add your js.
Attached is a patch without inline js.
It also removes the hook_init() in favor of including the js and css only on pages with node_view && livecoverage, and it works for me but I may not have the complete implications of my actions in mind :)
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | livecoverage-388854-4.patch | 885 bytes | kevin hankens |
| #5 | livecoverage-388854-5.patch | 834 bytes | kevin hankens |
| #3 | livecoverage-388854-3.patch | 2.04 KB | kevin hankens |
| livecoverage.js_settings.patch | 1.92 KB | jonskulski |
Comments
Comment #1
jonskulski commentedComment #2
jonskulski commentedComment #3
kevin hankens commentedYeah, that works perfectly. I was never happy about the inline JS and somehow missed the 'setting' option
Here's a /slightly/ revised patch for livecoverage.module to include some comments, etc.
Comment #4
kevin hankens commented-EDIT- Do not use this patch, instead use the following patch: livecoverage-388854-5.patch
Here is the livecoverage.js patch to use the Drupal.settings variables
Comment #5
kevin hankens commentedOops, that patch still included an alert() for debugging. Here's a new patch for the JS file.
Comment #6
kevin hankens commentedPatches committed.