Views bulk operation "add to nodequeue" gives all node the same position.

Thanks for taking the time to provide a screenshot! It looks like both symptoms you reported might be because the sqid column is not automatically incrementing.

Have you run the latest database updates, especially #5205 in update.php?

Did you upgrade from 5.x-2 or is this a fresh Drupal install?

Subscribing, greetings, Martijn

I'm having the same problem when uploading in bulk using Image import where the taxonomy is set for the image en-masse. All the positions end up as 1 and then when I look at them in Node Queue they are all listed until I save (even if I don't change anything) and I end up with only 2 nodes left in the sub-queue.

Ok, I think I've fixed this. nodequeue.module line 2092. Here's the new funtion (changed lines have ***):

<?php
/**
 * Add a node to a queue.
 *
 * @param $queue
 *   The parent queue of the subqueue. This is required so that we can
 *   pop nodes out if the queue breaks size limits.
 * @param $sqid
 *   The subqueue ID to add the node to.
 * @param $nid
 *   The node ID
 */
function nodequeue_subqueue_add($queue, &$subqueue, $nid) { // *** new: passing subqueue by reference.
  // If adding this would make the queue too big, pop the front node
  // (or nodes) out.

  if ($queue->size) {
    // 0 means infinity so never do this if false
    nodequeue_check_subqueue_size($queue, $subqueue, $queue->size - 1);
  }

  db_query("INSERT INTO {nodequeue_nodes} (sqid, qid, nid, position, timestamp) VALUES (%d, %d, %d, %d, %d)", $subqueue->sqid, $queue->qid, $nid, $subqueue->count + 1, time());
$subqueue->count++; // *** new: incrementing subqueue count here.
}
?>

Thanks. Could you roll this as a patch and explain the change you're making?

http://drupal.org/patch/create

Ok, here's a patch.

Basically what I did was change the function "nodequeue_subqueue_add ()" so that it will increment $subqueue->count after each insertion.

The SQL in that function is using $subqueue->count + 1 when inserting a new item into the nodequeue_nodes table, but since this is adding to a new subqueue the $subqueue->count == 0. Thus all batch uploads were inserting new items as position = 1 in table nodequeue_nodes.

This patch solves this problem by passing $subqueue->count by reference and adding $subqueue->count++; at the end of the function. Now all positions in batch uploads are incremented based on an accurate $subqueue->count.

You can always just edit the file directly from #5. There are only two lines of code that change.

Looks good to me, thanks! This is committed.

I remove your code comments -- No need to write your name in the code with CVS ;).

@mathis: You're probably having trouble with the links because there are still corrupt values in the nodequeue_nodes table -- You should probably clear out data related to the affected subqueues.

I remove your code comments -- No need to write your name in the code with CVS ;).

lol, thanks. I forgot to remove it for the patch, it's in my version for me to grep. Glad this is working. :)