This patch changes the default comment wrappers for javascript entries to be xhtml compliant as as far as I know is the most correct way to comment out Java Script code.

CommentFileSizeAuthor
#2 common.inc-D6.patch569 bytesstrategictech
#1 common.inc-D6.patch643 bytesstrategictech
common.inc-D6.patch127.03 KBstrategictech

Comments

strategictech’s picture

strategictech commented
StatusFileSize
new common.inc-D6.patch643 bytes

hopfully corrected Diff/Patch

strategictech’s picture

strategictech commented
StatusFileSize
new common.inc-D6.patch569 bytes

ok for real this time sorry bout all the mistakes...

ohnobinki’s picture

ohnobinki commented

What exactly are these patches supposed to change?

ohnobinki’s picture

ohnobinki commented
Issue tags: +xhtml compliance

tag

damien tournoud’s picture

damien tournoud commented
Status: Needs review » Closed (won't fix)

The way we output javascript is perfectly XHTML compliant.

On the other hand, this is very much broken:

$embed_prefix = "\n<!-- /* <![CDATA[ */\n";
$embed_suffix = "\n/* ]]> */ //-->\n";

... as it puts all the script in an HTML comment :)

strategictech’s picture

strategictech commented
Version: 6.10 » 6.24
Status: Closed (won't fix) » Active

Ok so how about this... which works, validates, and does not break all of the javascript on my sites using custom built themes?

  $embed_prefix = "\n/* <![CDATA[ */\n";
  $embed_suffix = "\n /* ]]> */ \n";

Status: Active » Closed (outdated)

Automatically closed because Drupal 6 is no longer supported. If the issue verifiably applies to later versions, please reopen with details and update the version.