On a node with 0 comments, the label says "0 Comment", while it should be "0 Comments". Please fix that.

Oh and by the way, you saved me from moving back to WordPress for this theme! I really needed a magazine theme and before you released this one there was nothing good available. Thanks a lot! :)

CommentFileSizeAuthor
#8 magazeen-template.php_.patch845 bytesmoritzz

Comments

pepemty’s picture

May I jump in on this issue?

Humbly, I think that it would be better yet if the comment label doesn't appear at all while there is no comment posted.

Your thoughts?

BTW, thanks for this wonderful theme concept.

Warm regards from my (oh too) sunny México!
:-)
José

niksiv’s picture

After thinking about it, I think the best option would be to have some text like "Add a comment now" or something similar to show when there is no comment. What do you think?

pepemty’s picture

Yes Nikolai, you are right. That way your reader will instantly know they are welcomed to make comments.

:-)

José

zinv’s picture

Originally I had the comments to remove the 's' add the end of the comment that is less than 1 since it make no sense to add an 's' for 0 comment.

@niksiv - I'll consider adding an option for that in the theme setting next.

Thanks for the comments -

BTW, The theme is in development , I hoping not to piss off a by releasing as 6.x-1.2. If anyone add a -beta at the end or a development snapshot leave a message.

dman’s picture

Slightly off-topic, but closely related, the 'comment' button comes up on teasers even when the comment.module is not enabled, or if comments are off for the node.
Not wanted.

I edited the middle of node.tpl.php like so:

		  <?php if ($teaser == 1): ?>
                          <?php if ($comment ): ?>       
  				<?php if ($comment_count > 1): ?>				
  				  <div class="comment-count">
  					  <a title="
  					  <?php 
  					    print $comment_count; 
  					    if ($comment_count > 1) { 
  					      print t('Comments'); 
  					    } 
  					    else { 
  					      print t('Comment'); 
  					    } 
  					  ?> 					 " href="<?php print $node_url .'#comments' ?>">
  					  <?php 
  					    print $comment_count; 
  					    if ($comment_count > 1) { 
  					      print ' ' . t('Comments'); 
  					    } 
  					    else { 
  					      print ' ' . t('Comment'); 
  					    } 
  					  ?> 
  					  </a>
            </div>				
          <?php else : ?>
            <?php print phptemplate_comment_count($comment_count, $node_url); ?>
          <?php endif; ?>	
        <?php endif; ?> 
					  	
        <?php if ($field_image_rendered): ?>
          <div class="post-image">
            <?php print $field_image_rendered; ?>
          </div><!-- /comment-count -->
        <?php endif; ?>
   <?php endif; ?>

- the only difference is <?php if ($comment ): ?> in there early.
Sorry for the indenting, it appears the theme code includes tabs :-(

Therefore not worth trying to submit a patch.

MikeAlbrecht’s picture

Also, regarding the above code and previous discussion,
$comment_count > 1
should be
$comment_count != 1

Same issue in comment-wrapper.tpl.php

TapSkill’s picture

No, that would only work for the distinction between "Comment" and "Comments"; not whether or not to show that format. It does solve the immediate problem, though. In any case, this is simple coding, so anyone with even a tiny bit of PHP experience (or any programming knowledge) can fix it. I wonder why it hasn't been committed to a bugfix release, though. Is there no maintainer?

moritzz’s picture

Title: Please Fix Comments Label » Plural setting for comment count gets not reflected
Version: 6.x-1.2 » 6.x-2.0-alpha2
Status: Active » Needs review
StatusFileSize
new845 bytes

The attached patch for template.php fixed this on my site.

sheena_d’s picture

Status: Needs review » Closed (fixed)

Hi,

Maintenance of this theme has changed hands and we are no longer supporting this version of the theme. You may want to try upgrading to see if that fixes your problems. Sorry for any inconvenience.

Thanks,
Sheena