The $_SESSION['not_slavesafe'] hacks on d.o are broken. See #381704: sporadic node_load() failures causing grief for the d.o packaging script for an example. The patch was never properly ported to D6 core, and it's a hack anyway, since it assumes the replication delay is equivalent to a single page load. David wants to just backport #314358: Add option to ignore slave server for next requests to d.o D6 core. This involves:

A) Backporting it into core
B) Patching drupalorg.module to call it at the right times
C) Patching the packaging script to set it before node_load()

David's working on (A), I'm doing (B) and (C).

Comments

dww’s picture

Status: Active » Needs review
StatusFileSize
new1.48 KB
new771 bytes

Patches for drupalorg.module and package-release-nodes.php

dww’s picture

StatusFileSize
new1019 bytes

Actually, based on David's backport (http://vcs.fourkitchens.com/pressflow/6-patches/database-replication/rev...) we don't need any of this code in drupalorg.module at all.

dww’s picture

Status: Needs review » Fixed

Ok, David merged his changes into SVN, I committed the above to DRUPAL-6--1 and HEAD of drupalorg, and to HEAD of project. We deployed on d6.d.o, and everything seems fine. So, we deployed this for real on d.o. Let's hope this solves it once and for all.

Status: Fixed » Closed (fixed)
Issue tags: -drupal.org upgrade

Automatically closed -- issue fixed for 2 weeks with no activity.

Project: Drupal.org infrastructure » Drupal.org customizations
Component: Drupal.org module » Miscellaneous