Further optimize CSS files

okay thanks I'm setting up the cvs and I'll make a patch thanks again Arie

Marcus

patch :

Thanks you very much. Mr. baileys

I'll read the coding standards and look in to the preg_replace and see if I can move it to drupal_load_stylesheet

I save about 300 - 500 bites on my sites (a bite per css command), so not a lot, but I like to have the smallest output I can.

Marcus

I am new it using reg exp what am i doing wrong?

got this working

<?php
print preg_replace('/[;]+(?=})/' , '\1' , 'fieldset {margin-bottom: 1em;  padding: .5em;}form { margin: 0;  padding: 0;}hr {height: 1px;  border: 1px solid gray;}');
?>

but how do I add it to the code in drupal_load_stylesheet?
Here is my attempt below (my line with <<<) got no errors just dus not 'Remove semi-colons on the ending declaration for a rule.'

<?php
print preg_replace( '<
\s*([@{}:;,]|\)\s|\s\()\s* |  # Remove whitespace around separators, but keep space around parentheses.
   /\*([^*\\\\]|\*(?!/))+\*/ |   # Remove comments that are not CSS hacks.
 [\n\r]|                     # Remove line breaks.
 [;]+(?=})                   #<<< Remove semi-colons on the ending declaration for a rule.
>x', '\1', 
/*
**Added defaults.css to test.
*/
'/* $Id: defaults.css,v 1.5 2007/10/02 12:10:40 dries Exp $ */

/*
** HTML elements
*/
fieldset {  margin-bottom: 1em;  padding: .5em;}form {  margin: 0;  padding: 0;}hr {  height: 1px;  border: 1px solid gray;}
img {  border: 0;}
table {  border-collapse: collapse;}
th {text-align: left; /* LTR */ padding-right: 1em; /* LTR */ border-bottom: 3px solid #ccc;}

/*
** Markup free clearing
** Details: http://www.positioniseverything.net/easyclearing.html
*/
.clear-block:after {
  content: ".";
  display: block;
  height: 0;
  clear: both;
  visibility: hidden;
}

.clear-block {
  display: inline-block;
}

/* Hides from IE-mac \*/
* html .clear-block {
  height: 1%;
}
.clear-block {
  display: block;
}
/* End hide from IE-mac */
');
?>

Updating to support Request as I need help. thanks

thanks Arie
I can't get that to work as part of preg_replace that's already there,

I could do:

<?php
    if ($_optimize) {
      // Perform some safe CSS optimizations.
      $contents = preg_replace('<
        \s*([@{}:;,]|\)\s|\s\()\s* |  # Remove whitespace around separators, but keep space around parentheses.
        /\*([^*\\\\]|\*(?!/))+\*/ |   # Remove comments that are not CSS hacks.
        [\n\r]                        # Remove line breaks.
        >x', '\1', $contents);
        $contents = preg_replace('/[;]+(?=})/' , '' , $contents); // Remove semi-colons on the ending declaration for a rule.
    }
?>

but if it is speed we need :

<?php
    if ($_optimize) {
      // Perform some safe CSS optimizations.
      $contents = preg_replace('<
        \s*([@{}:;,]|\)\s|\s\()\s* |  # Remove whitespace around separators, but keep space around parentheses.
        /\*([^*\\\\]|\*(?!/))+\*/ |   # Remove comments that are not CSS hacks.
        [\n\r]                        # Remove line breaks.
        >x', '\1', $contents);
        $contents = str_replace(';}' , '}' , $contents); // Remove semi-colons on the ending declaration for a rule.
    }
?>

I think is faster as it is simple. I was hoping to add it to the preg_replace function, but it hard for me not knowing about Regular Expressions, but learning slowly.

hi
Looking in to the bytes save it is 2 bytes per css command so on testing 10 sites I saves about 1000 bytes per site. see how much you can save ;-}

Marcus

opps, yes I agree, thanks