If I change my mind about adding an aggregate group when I first select it, I can't use cancel or remove. I have to complete adding it, and then I can go back and remove it.

Otherwise, very nice work. I was actually thinking about how one would go about adding exactly this module. Thanks for saving the Drupal community from my code :) Now if there was just a way to make a node-to-node relationship/link, I'd be all set.

Comments

irakli’s picture

irakli commented
Status: Active » Postponed

Thanks, Colin.

Code is still early alpha and things are a little flaky.

colin_young’s picture

colin_young commented

Yeah, I'm aware of that :)

Just wanted to file it in case you didn't come across it (I'm not sure it's something you'd normally do -- start adding a field and then immediately cancel).

rsevero’s picture

rsevero commented
Project: Views Group By » Views (for Drupal 7)
Version: 6.x-1.x-dev » 6.x-2.x-dev
Status: Postponed » Active

This is a Views issue. It isn't specific to Views GroupBy as any form with a required field will present this behavior in Views.

dawehner’s picture

dawehner
Primary language German
commented

I don't think this is fixable because required is validate on the form values all the time.

For me this sounds like a minor feature request ;)

iamjon’s picture

iamjon commented
Status: Active » Closed (won't fix)

I asked about this issue on irc and from what I understand fixing this issue

in D6 requires ugly hacks (since Cancel buttons always run the form validation) [and]
it's not Views specific, it's Drupal Core specific..

Thanks bojanz.

So I'm marking this as closed. Please feel free to reopen the issue or refile it against core.

Best regards

bojanz’s picture

bojanz commented
Status: Closed (won't fix) » Active

merlinofchaos: Set #validate on the cancel button to array()
merlinofchaos: See if that actually works.
merlinofchaos: Tho hm. I thought cancel already tried to do that.

iamjon’s picture

iamjon commented
Assigned: Unassigned » bojanz

Assigning to bojanz for review

bojanz’s picture

bojanz commented
Status: Active » Fixed

I just clicked through 6.x-2.x, 6.x-3.x, and the new UI, and hitting Cancel / Remove when adding an item with validation works (for example, the Node: Created filter).
If I missed it somewhere, let me know.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.