Download & Extend

"Delete this and later bids" doesn't work with double digit BID's

Project:Ubercart Auction
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:active
Issue tags:delete this and later bids, uc_auction, uc_auction_bids

Issue Summary

HI. This is a great module. Great job.

In testing, I noticed that the "Delete this and later bids" doesn't work when you have lots of auctions. I am developing a auction for a non-profit that has over 35 auctions. When the BID's in "uc_auction_bids" get larger than 2 digits, when clicking on "Delete this and later bids", it doesn't update "uc_auction" "high_bid" in the database with the correct number.

I tested by manually modifying the database with various BID's to see what worked. It is probably something in uc_auction.module around line 971 which has to be changed but unsure what that might be.

I also thought it may be another module I installed which is conflicting in some way. Upon doing a clean install with just ubercart, ubercart auction, and required modules, it did the same thing with double digit BID's in "uc_auction_bids".

Thanks so much for the help. Any ideas?

Comments

#1

I don't think double digit bid ID values are the issue. For one, because I can't see why it would be, and for two, because I just tested deleting some bids with bid IDs well above 10 on our client's site, and everything went fine.

This could be a bug in the older code; something which will be fixed once the Drupal.org robot finally updates the dev release. I just did another commit. If I don't see a new package when I get off of work tomorrow, I'll go annoy chx in #drupal - he's been unreasonably helpful with me and my CVS/packaging robot problems in the past.

#2

Thanks Garrett.

#3

Issue #396138: Deleting bids resets bid price to $45. outlines a similar problem, but it seems to have been resolved by the most recent (and finally correct) dev release. jesse, could you give it a try and let me know if it resolves the issue?

#4

I'm seeing a similar problem in the latest dev release. The site only has one auction going at a time.

After removing the highest bid on the current auction, the "high bid" reverts to the first bid of a previous auction. Looking at the high_bid field in uc_auction_bids table in the db, it had a value of "3" instead of the required "31". To fix the problem, I manually changed high_bid to the correct value.

I'm not sure what else is relevant here, please let me know if you require further information.

#5

I think the problem with this is because the return value of $max is actually a string, not an array.
So what I've done at function uc_auction_bid_del_conf_submit is implementing this:

$auc_record = array(
'nid' => $node->nid,
'high_bid' => (is_array($max) ? $max['bid'] : $max), // before was $max['bid']
// $max['bid'] may be FALSE, which will be inserted as 0 (which is what we want).
);

Hope this is helping you guys.

nobody click here