Hi,
First let me say that this module is EXACTLY what I needed today! Thank you so much for sharing! You saved me a lot of time!

My issue is popping up when I set the comments to "oldest on top" rather than the default "newest on top" (ascending vs. descending) To place the new comment, your code targets the comment section title, and places the new comment "after" This is fine when the newest posts are on top, but I initially wanted the oldest on top, and would need to refresh the page to see that change.

The variable for comment order is stored in the variables table under comment_default_order_* where the * is the content type (I believe) So I would think that a getvariable(comment_default_order_page) and some conditional statements would do the trick. (Though my coding is a bit rusty so don't take my word on it)

I will try fix on my own, and post the code if successful. If you have any idea they'd be appreciated! Thanks again for a useful module.

I was also wondering if you know anything about the memory usage of this module. If I have a hundred people in the room all getting live updates on comments from each other... how much server memory will I be using? Is there a way to test?

Comments

jonskulski’s picture

jonskulski commented

As of now the live_update_comment.module is not sensitive to the comment ordering. This is very much a dev release, and will support this by the alpha/beta release of the module. However, it's not a top of the list as we are focusing on the API so I would welcome a patch!

As for scalability, it is a focus and strength of the module. The reason for our use of flat files (.txt) is that apache can serve them quickly, without requiring a drupal bootstrap, and possibly with aggressive caching. A big upcoming feature is integration with memcached which would speed things up even more (if enabled)

jonskulski’s picture

jonskulski commented
Component: Code » live_update_comment
Status: Active » Fixed

This is fixed in HEAD.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.