Download & Extend
String Overrides » Issues

Import of an override with blank msgstr fails

Posted by Mark Theunissen on March 4, 2009 at 5:52pm
Project:String Overrides
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Rob Loach
Status:closed (fixed)

Issue Summary

I use string overrides to remove some strings completely. The problem is that when I import a .po file with an empty msgstr, it gets discarded. The patch just removes the check ...

if (!empty($currentstring) && !empty($currentoverride)) {

becomes:

if (!empty($currentoverride)) {

Thanks!

Login or register to post comments

Comments

#1

Posted by Mark Theunissen on March 4, 2009 at 5:53pm
AttachmentSize
stringoverrides-import_empty-391086-1.patch 882 bytes

#2

Posted by Rob Loach on March 5, 2009 at 8:27pm
Assigned to:Mark Theunissen» Rob Loach
Status:needs review» reviewed & tested by the community

#3

Posted by Rob Loach on March 8, 2009 at 10:38am
Status:reviewed & tested by the community» fixed

Committed! Thanks!

#4

Posted by System Message on March 22, 2009 at 10:40am
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here