As the dashboard.css file is imported in hook_view, it can be imported more than once if a site is displaying more than one dashboard on a single page.

Attached patch fixes this by placing the drupal_set_head() call in hook_menu() instead, which I is the correct place. I've also altered the call to get the path to the module/CSS file properly using drupal_get_path() instead of $GLOBALS[base_url].

Note this issue applies to 4.6 version, too: patch on its way.

CommentFileSizeAuthor
#1 dashboard.module_insert_css_correctly_0.patch1 KBpfaocle
dashboard.module_insert_css_correctly.patch1 KBpfaocle

Comments

pfaocle’s picture

pfaocle
He/Him
Primary language English
commented
StatusFileSize
new dashboard.module_insert_css_correctly_0.patch1 KB

The rest of that post:

Attached patch fixes this by placing the drupal_set_head() call in hook_menu() instead, which I think is the correct place. I've also altered the call to get the path to the module/CSS file properly using drupal_get_path() instead of $GLOBALS[base_url].

merlinofchaos’s picture

merlinofchaos commented
Assigned: Unassigned » merlinofchaos
Status: Needs review » Fixed

Patch applied and committed.

Thank you!

(This points out that no matter how much I think I've figured out about The Right Way to do things in Drupal, there's always something else I didn't notice)

pfaocle’s picture

pfaocle
He/Him
Primary language English
commented

Fastest. Contrib. Commit. Ever.

Nice one!

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)