Comments for Activity 2.x

Comments:
1.) remove all JavaScript and use AHAH (http://drupal.org/node/331941 and http://api.drupal.org/api/drupal/developer--topics--forms_api_reference....)

$form['submit'] = array(
    '#type' => 'submit',
    '#value' => t('add'),
    '#ahah' => array(
      'path' => 'activity/comments/insert',
      'wrapper' => 'activity_comments-' . $aid,
      'method' => 'replace',
      'effect' => 'fade',
    ),
    '#submit' => array('activity_comments_form_submit'),
  );

and

/**
 * Insert comments menu callback.
 */
function activity_comments_comment_insert() {
  drupal_set_message('go');
  // We're starting in step #3, preparing for #4.
  $form_state = array('storage' => NULL, 'submitted' => FALSE);
  $form_build_id = $_POST['form_build_id'];
  // Step #4.
  $form = form_get_cache($form_build_id, $form_state);

  // Preparing for #5.
  $args = $form['#parameters'];
  $form_id = array_shift($args);
  $form_state['post'] = $form['#post'] = $_POST;
  $form['#programmed'] = $form['#redirect'] = FALSE;

  // Step #5.
  drupal_process_form($form_id, $form, $form_state);
  $limit = $form_state['values']['limit']; // The form item will have a '#type' => 'value' called limit for this purpose
  // Step #9.
  $output = theme('status_messages') . theme('activity_comments_comments', $comments, $limit); // @TODO add in all comments for this activity here

  // Final rendering callback.
  drupal_json(array('status' => TRUE, 'data' => $output));
}

2.) theme function for all comments needs to render ALL the comments and those that are below the limit need to be hidden by CSS. Add a simple link to then show All

/**
 * Views row style theme function for embed comments display.
 * 
 * Don't add a wrapper around the comments, it breaks the AJAX functionality.
 * 
 * @todo move to tpl.php file?!
 */
function theme_activity_comments_comments($comments = array(), $limit) {
  $items = array();
  $count = 0;
  foreach($comments as $comment) {
    if (++$count > $limit) {
      theme('activity_comments_comment', $comment, TRUE); // where TRUE tells the activity_comments_comment theme function to hide it
    }
    else { 
      $items[] = theme('activity_comments_comment', $comment);
    }
  }
  return theme('item_list', $items) . l('show all', '#', array('html' => TRUE, 'attributes' => array('class' => 'activity-comments-show-all'))));
}

Write a JS file that uses Drupal.behaviors instead of document.ready(), and attach to show all a click function.

Drupal.behaviors.activityCommentsShowAll = function (context) {
  $('.activity-comments-show-all:not(activity-comments-show-all-processed)'.click( 
  // show the rest and flip the direction so next click will hide them
).addclass('activity-comments-show-all-processed');
};

3.) Remove drupal_add_js('jquery.forms') this is added by the expand_ahah process function, no need for it in the handler.

Ok so there is some of the issues I see. Not all code here will work as written, i have written them only here in this textarea not in an IDE. There are other issues as well with things like code style http://drupal.org/coding-standards

But this should get you started again.

Ok so pretty excited about this. i reworked it and I think i got it setup so it should be easy to extend. I compressed the 3 fields (activity all link, comment form, and the comment listing) into one field. Its a form with a bunch of markup in it. Using form_alters you should be able to move things around pretty easily.

It also works without JS (even the CSS rules handle that case as well).

Uses AHAH for the form submission. Lil bit of JS to handle the Default text (focus, blur events) and the 'show all' link.

What I need help with is getting rid of the damn list styling...

.item-list ul.activity-comment-list {
  list-style: none;
  margin: 0.35em 0 0 0.5em;
}

that didn't work. And any other styling, Im pretty blah at CSS.

Heres a screen shot
http://skitch.com/supermanscott/ndcc5/scotts-contrib

Forgot to add in the additional permission to the form wrapper so anon users for instance couldn't post if they weren't allowed via admin/user/permissions

I also like it better without the form label ('#title')

$form['activity_form_items']['activity_comment'] = array(
    '#type' => 'textfield',
    '#maxlength' => 250,
    '#size' => 32,
    '#default_value' => t('Write a comment'),
    '#attributes' => array('class' => 'activity-comment-text'),
  );

That has to do with the AHAH stuff and its pretty strange. It basically is telling us that Drupal.ahah didn't post the form values properly.

Have you used a previous version of this before?

Are you sure the activity_comments.js is the proper one? As the old JS file grab the form button and posted other values that wouldn't match what AHAH posts. And because I didn't change the menu path, it will cause problems. Problems just like this.

Ok spent some more time on this today

http://skitch.com/supermanscott/ndi5i/activity-comments

Improvements / Fixes

1. AHAH doesn't mess up the html structure :-D
2. Made sure the form submit buttons always had unique id that was reproducible on each rendering (fixed AHAH not attaching after adding a comment)
3. Moved Show All up to above the comment lists
4. Added the count of the comments to the show all title (says Show all X comments)
5. made activity_comments_comment into a template file
6. fixed security hole in theme layer by check_plain the comment body
7. removed ability to expand collapse. Facebook doesn't do this and i figure they had some usability testing for this. Also made the JS simpler which I like
8. improved default styling

TODO

1. Delete comment. Write an menu access callback and leverage that when rendering the link in the 'form'
2. JS cleanup

This is much closer to a finished product. Please take a chance to review.

@sirkitree do we want this to be rolled in with Activity download or would it be nicer as a separate project? drupal.org/project/activity_comments is open.

Also, I looked into auto growing the comment form like Facebook does. Involves a lil more JS but doable. There is a jQuery plugin that might do this ? sortof...
http://plugins.jquery.com/project/autogrow

Really what Facebook does is on focus add rows to the textarea and show the submit button.

Open Questions

1. Do we make the comment a textarea with a format? This would allow for WYSIWG as well as the autogrow thingie. Perhaps a textarea is more appropriate its what is used for node comments.
2. Do we want to toggle expand/collapse? I followed Facebook for this question but willing to debate
3. Do we make this a separate downloadable project?

Probably also need some JS clean up

• surround the behaviors in the function( jquery thingie) following D7 coding sugguestions

•     form_id = $(this).parents('form').parents('.activity-comments-hide-comments').removeClass('activity-comments-hide-comments');
  

  becomes

  $(this).parents('.activity-comments-hide-comments').removeClass('activity-comments-hide-comments');
  

it means additional ~1-500 comments

I took my facebook feeds a 'representative' sample of the number of comments on messages. I had a total of 64 comments on 65 Facebook messages for an average of .98 comments per activity.

And thats Facebook. Who here knows of any site doing the same amount of traffic as Facebook? Not so sure its worth the effort.

I guess I would argue I don't want this performance improvement to hold it up. And it does add a level of trouble. It will slow down frontend performance (now its just a class toggle which means Show All is nearly instantaneous). You have to keep track of values and add another menu callback. There is some work there and its non-trivial.

Edit: The mode of the data was 8.

With this module, would an activity comment on that message be related to the activity message itself, or would it be posted as the next comment attached to the node XYZ?

The comment is attached only to the activity message.

Addressed my TODOs from #24

One issue is the delete. It uses the drupal_get_destionation(). Which is fine usually. But if you were to submit a new comment. Then delete that comment, the redirect would be to the JS callback not back to the View.

It is because the drupal_get_destination() for the AHAH callback. The form will have to pass in the current path to the AHAH callback somehow? Not sure on how to achieve just yet.

alippai asked me what was missing for this project so far

Here is my short todo
1.) Delete after you post a comment redirects you to the JSON response page. yuck
2.) Should we toggle expand and collapse instead of a show all. FB doesn't do that, but...
3.) Do we make the comment a textarea with a format? This would allow for WYSIWG as well as the autogrow thingie. Perhaps a textarea is more appropriate its what is used for node comments.

At least for number 3, we need to come up with an answer only because as a Feature request this will surface, so we better have a thought out answer for it.

Any thoughts on #33's three points. Would like to commit a patch this weekend

ok change that to this as the above didn't affect the delete link which was the problem. And it prevents it from running on all the comments that have already been processed

/**
   * Hanldes the destination for the delete link
   */
  Drupal.behaviors.activityDestination = function(context){
    $('.activity-comments-delete a:not(.activity-destination-processed)').each(function() {
      var href = $(this).attr('href').split('?destination=')[0] + '?' + Drupal.settings.activity_comments.destination;
      $(this).attr('href', href).addClass('activity-destination-processed');
    });
  };

still a problem with Views3. we hard code aid

return drupal_get_form('activity_comments_form', $values->aid, $this->options['limit'], $this->options['order']);

Hopefully, i can improve once more then I will commit

I think this is it. Would love a review

Ahh right so that default view needs to go. I have forgotten about that.

What you really want to do to create a View is this
http://skitch.com/supermanscott/nek79/edit-view-all-activity-scotts-contrib

Meant to note it needs work

Ok so in order to post comments, you need to use the field as describe in 41 (http://skitch.com/supermanscott/nek79/edit-view-all-activity-scotts-contrib)

But I decided to add a 'feature' that was partically implemented before, create a View of all the comments. So now you can do this:
1.) Create a View just of Activity Comments: http://skitch.com/supermanscott/nexim/views-scotts-contrib
2.) Relate this View to bring in more fields/filters/arguments http://skitch.com/supermanscott/nexic/edit-view-comment-test-scotts-contrib
3.) Add in these fields: http://skitch.com/supermanscott/nexit/edit-view-comment-test-scotts-contrib

I also removed the broken default view that referenced the old style plugin. Fixed a number of bad views handlers (views_handler_(field/filter)_number doesn't exist, its numeric)

We are close. I would like to store the last comment id in the stats table so that it can be pulled in along side the Activity View if you aren't using the comment form handler.

Does all this make sense?

Ok committed a minimal implementation that handles what I think is the 90% case. It provides three fields for an Activity View, one is for posting comments, one is the comment count and the other is the comment timestamp.

The two remaining sub issues:
#683124: Create Activity Comments as a base table
#683130: Rules Integration for posting an Activity Comment

http://drupal.org/cvs?commit=313486