From http://www.drupalusability.org/node/9:

The admin/by-module page generates links like:
<a href="/admin/user/permissions#module-my-module">Configure permissions</a>

But the admin/user/permissions page generates anchors like:
<td class="module" id="module-My Module" colspan="21">Comment</td>

CommentFileSizeAuthor
#3 392582.002.patch1.25 KBkarschsp
#1 392582.001.patch1.27 KBkarschsp

Comments

karschsp’s picture

karschsp commented
StatusFileSize
new 392582.001.patch1.27 KB

Here's a quick patch for this.

karschsp’s picture

karschsp commented
Status: Active » Needs review

forgot to change status.

karschsp’s picture

karschsp commented
StatusFileSize
new 392582.002.patch1.25 KB

re-rolling patch to use ['#id'] rather than ['#anchorname']

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Issue tags: +Needs tests

Awesome. It's much better using #id, and consistant with current FormAPI conventions.

We should also get some quick tests written to make sure this doesn't break again. Do we have any tests that work with the admin/by-module page?

cburschka’s picture

cburschka
they
commented
Status: Needs review » Reviewed & tested by the community

This is just two lines, and both looked okay at a glance. The internal module name is safe to use here, since they are guaranteed to be unique.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks!

Ideally, we'd have a generic broken link tester at some point.

Status: Fixed » Closed (fixed)
Issue tags: -Usability, -Needs tests, -Novice, -UBUserTesting2009

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Usability, +Needs tests, +Novice, +UBUserTesting2009

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.