Posted by Dave Reid on March 6, 2009 at 1:23am
| Project: | Drupal core |
| Version: | 7.x-dev |
| Component: | user.module |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
| Issue tags: | Needs tests, Novice, UBUserTesting2009, Usability |
Issue Summary
From http://www.drupalusability.org/node/9:
The admin/by-module page generates links like:<a href="/admin/user/permissions#module-my-module">Configure permissions</a>
But the admin/user/permissions page generates anchors like:<td class="module" id="module-My Module" colspan="21">Comment</td>
Comments
#1
Here's a quick patch for this.
#2
forgot to change status.
#3
re-rolling patch to use ['#id'] rather than ['#anchorname']
#4
Awesome. It's much better using #id, and consistant with current FormAPI conventions.
We should also get some quick tests written to make sure this doesn't break again. Do we have any tests that work with the admin/by-module page?
#5
This is just two lines, and both looked okay at a glance. The internal module name is safe to use here, since they are guaranteed to be unique.
#6
Committed to CVS HEAD. Thanks!
Ideally, we'd have a generic broken link tester at some point.
#7
Automatically closed -- issue fixed for 2 weeks with no activity.