Real Name integration with core Search Module / users

This would be a feature request. I dislike dealing with search almost as much as WYSIWYG modules... But you are right, this needs to be in there.

Please try the attached patch. It uses the standard search item limit.

Attachment	Size
realname_6x_07.patch	1015 bytes

No, that only indexes it. More in a bit.

Let's try this one. The search will work for either RealName or user name. Unlike the user module, it will not search on the mail address.

Attachment	Size
realname_6x_07.patch	2.96 KB

I committed this patch. I want to get a new release out and wanted some testing before I had to commit it.

Sorry, NancyDru, I'm just getting back around to this.

Trying the March 12 -dev release, I'm not getting a realname match on user searches, even after forced re-indexing.

There should be a roll-up occurring any minute now; it will be dated either March 13 or 14. You could also use the patch.

Worked for me. I logged in as an unprivileged user and searched for my first name. The result came up in the "User name" tab (but not in the "Users" tab). The result showed my real name in both the "Login name" and "User" fields. I would prefer not to get any "Login name" information as a search result at all, because the reason of using the RealName module is to avoid unveiling usernames as good as possible. But this way it's just redundant information.

I just did a change that will only show that info to people with 'administer users' permission.

The "Users" tab comes from the User module; I have no control over it.

Good, now the "Login name" information will no longer be shown to unprivileged users. However, they are still able to search for a login name and then get the matching real name as a result. Isn't the main purpose of RealName to hide the login names wherever possible?

Well, that actually was not my original intent, but it does seem to be the intent of many of you who are using it. The reason I have the login name in the search index is so the admin can more easily find a user. Is this not necessary?

That is totally OK for admins, but IMO users that don't have the administer users permission should not be able to unveil login names at all. That also includes finding them from the search index, which can often be a security problem.

I'm making it an option whether or not to index them. But the commit will have to wait for me to get back from church.

Very great, Nancy! The 2009-Mar-16 dev version of 6.x-1.x with the new Search options

works perfectly for me! The realname.module search could than be a more secure replacement for the user.module search feature. Now when there would be an option to remove user.module's search tab, that would be perfect.

I didn't have that option because I hadn't figured out how. The Search module has a very interesting hook_menu...

But check your "general" setting tab now...

Thank you for the new Disable user search option! I enabled it, which hides the tab linked to the user.module search. However, user.module's search is still active when accessed directly via it's URL.

I would suggest a feature request against the user module to make it optional.

I'm not crazy about completely deleting a core-provided menu item. Unless you think it's going to be a major problem leaving an invisible menu item (and there are many in core even), I'm inclined to leave it as is.

No problem here - thus I have decreased the priority to minor. The way it is now is totally OK for me. Thanks for the new search feature anyway.

A side effect of the enabled Disable user search option is that every now and then I am on an admin page, the message User module search disabled. appears prominently.

The problem mentioned in my reply #21 persits also in the latest dev version from today (2009-Mar-20). Every time I go to admin/build/modules, the info message is shown on the top.

It should be coming out only when you rebuild the menus, which admin/build/modules will do. I guess I should change that somehow.

I moved the message to the admin page.