Actions are displayed in wrong order
DamienMcKenna - March 6, 2009 - 05:33
| Project: | Taxonomy Redirect |
| Version: | 6.x-1.3 |
| Component: | Code |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Description
The form action field (Remove Text, Separator, Path Case) are displayed in the opposite order of how they are processed, they should be displayed in the same order to make it clear how to configure the options.
#1
Patch attached.
#2
Thanks for the various patches Damien. Feel free to post one big patch which addresses multiple issues :)
#3
Here's one patch file that covers the following issues:
* #392618: "load into editor" skips the Category field
* #392626: Rewrite JS calls using jQuery
* #392732: Starting path with placeholder can lead to incorrect paths
* #392752: Actions are displayed in wrong order
#4
Thanks for the patches.
With this one though (#392752: Actions are displayed in wrong order) I don't see the problem.
I just installed a fresh download of 6.x-1.3 and the order of the fields in the table is:
Vocabulary, Term, Path, Path Case, Separator, Remove Text, View in editor, delete
The order of the add redirect fields is:
Vocabulary, Filter, Term, Path, Path Case, Separator, Remove Text
All the options that are in both are in the correct order.
The #392752 patch actually puts them in the wrong order when I try it.
#5
@agileware: I'm talking about the Add New form vs how the code processes the requested path string.
When I view the Add New Redirect form in 6.x-1.3 this is the order:
When I view the code (taxonomy_redirect_default_term_path() in taxonomy_redirect.module) it is in this sequence:
My patch resolves this so they show in the same sequence as the code so there's no ambiguity on how the path will be processed.
#6
Committed to 5.x-1.x and 6.x-1.x branches.
#7
Automatically closed -- issue fixed for 2 weeks with no activity.