Adding title attribute with description to terms [#393494]

This patch adds a title attribute to each term which will show the description of the term as a tool tip when hovering with the mouse over the term. (This is the default behavior with taxonomy terms when shown in nodes.)

The feature was requested in http://drupal.org/node/390870 and the solution described in http://www.drupalcenter.de/node/16915 (including screenshots).

Frank

Comment	File	Size	Author
#9	393494_Tagadelic_title_tags.png	2.35 KB	frank ralf
#8	393494.jpg	24.44 KB	tobiasb
#5	tagadelic_393494_title_attributes4.patch	1.57 KB	tobiasb
#3	tagadelic_393494_title_attributes3.patch	1.62 KB	tobiasb
#2	tagadelic_393494_title_attributes2.patch	1.76 KB	frank ralf
#1	tagadelic_393494_title_attributes.patch	1.71 KB	frank ralf

Comments

Comment #1

frank ralf commented 6 March 2009 at 21:25

Status	File	Size
new	tagadelic_393494_title_attributes.patch	1.71 KB

Comment #2

frank ralf commented 7 March 2009 at 12:34

Status	File	Size
new	tagadelic_393494_title_attributes2.patch	1.76 KB

Slightly improved patch as recommend in http://www.drupalcenter.de/node/16915#comment-59445

substituted function strip_tags($term->description) (originally from taxonomy.module, line 64) by check_plain() (http://api.drupal.org/api/function/check_plain)
deleted quotes
better indentation

Frank

Comment #3

tobiasb

German

Berlin

commented 7 March 2009 at 17:24

Status	File	Size
new	tagadelic_393494_title_attributes3.patch	1.62 KB

Comment #4

frank ralf commented 8 March 2009 at 12:41

Thanks for checking the code and improving it!

I had another look at the context of that title attribute code in taxonomy.module and tagadelic.module and found that neither strip_tags() nor check_plain() is actually needed in tagadelic.module because here the whole is wrapped in the link function l() which cares itself for removing all HTML and PHP tags from a tooltip:

  // Remove all HTML and PHP tags from a tooltip. For best performance, we act only
  // if a quick strpos() pre-check gave a suspicion (because strip_tags() is expensive).
  if (isset($options['attributes']['title']) && strpos($options['attributes']['title'], '<') !== FALSE) {
    $options['attributes']['title'] = strip_tags($options['attributes']['title']);
  }

So the change in tagadelic.module can be simplified to 'title' => $term->description,.

Frank