Download & Extend
Tagadelic » Issues

Adding title attribute with description to terms

Posted by Frank Ralf on March 6, 2009 at 9:22pm
Project:Tagadelic
Version:6.x-1.x-dev
Component:Code
Category:feature request
Priority:normal
Assigned:Frank Ralf
Status:closed (fixed)

Issue Summary

This patch adds a title attribute to each term which will show the description of the term as a tool tip when hovering with the mouse over the term. (This is the default behavior with taxonomy terms when shown in nodes.)

The feature was requested in http://drupal.org/node/390870 and the solution described in http://www.drupalcenter.de/node/16915 (including screenshots).

Frank

Login or register to post comments

Comments

#1

Posted by Frank Ralf on March 6, 2009 at 9:25pm
AttachmentSize
tagadelic_393494_title_attributes.patch 1.71 KB

#2

Posted by Frank Ralf on March 7, 2009 at 12:34pm

Slightly improved patch as recommend in http://www.drupalcenter.de/node/16915#comment-59445

  1. substituted function strip_tags($term->description) (originally from taxonomy.module, line 64) by check_plain() (http://api.drupal.org/api/function/check_plain)
  2. deleted quotes
  3. better indentation

Frank

AttachmentSize
tagadelic_393494_title_attributes2.patch 1.76 KB

#3

Posted by tobiasb on March 7, 2009 at 5:24pm
AttachmentSize
tagadelic_393494_title_attributes3.patch 1.62 KB

#4

Posted by Frank Ralf on March 8, 2009 at 12:41pm

Thanks for checking the code and improving it!

I had another look at the context of that title attribute code in taxonomy.module and tagadelic.module and found that neither strip_tags() nor check_plain() is actually needed in tagadelic.module because here the whole is wrapped in the link function l() which cares itself for removing all HTML and PHP tags from a tooltip:

<?php
  // Remove all HTML and PHP tags from a tooltip. For best performance, we act only
  // if a quick strpos() pre-check gave a suspicion (because strip_tags() is expensive).
  if (isset($options['attributes']['title']) && strpos($options['attributes']['title'], '<') !== FALSE) {
    $options['attributes']['title'] = strip_tags($options['attributes']['title']);
  }
?>

So the change in tagadelic.module can be simplified to 'title'  => $term->description,.

Frank

#5

Posted by tobiasb on March 9, 2009 at 10:25am
AttachmentSize
tagadelic_393494_title_attributes4.patch 1.57 KB

#6

Posted by Frank Ralf on March 9, 2009 at 12:18pm

Thanks!

#7

Posted by Bèr Kessels on March 10, 2009 at 7:11am

I like it.

Can someone please give it a quick test on a site with real information?
After one or more positive tests, I will commit it to HEAD and Drupal 6.x.

#8

Posted by tobiasb on March 25, 2009 at 3:17pm

Looks ok. see screenshot.

AttachmentSize
393494.jpg 24.44 KB

#9

Posted by Frank Ralf on April 15, 2009 at 4:42pm

Does work as promised (see screenshot). I really would like to see it committed to HEAD.

tia
Frank

AttachmentSize
393494_Tagadelic_title_tags.png 2.35 KB

#10

Posted by Frank Ralf on April 15, 2009 at 4:46pm
Status:needs review» reviewed & tested by the community

changed status

#11

Posted by Frank Ralf on April 15, 2009 at 4:46pm

changed status

#12

Posted by Bèr Kessels on May 13, 2009 at 4:56pm
Version:6.x-1.2» 6.x-1.x-dev
Status:reviewed & tested by the community» fixed

Committed to 6 dev.

#13

Posted by Frank Ralf on May 14, 2009 at 6:57am

Thanks!

#14

Posted by System Message on May 28, 2009 at 7:00am
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.