Converting filter module to DBTNG at Drupalcon DC code sprint.

CommentFileSizeAuthor
#8 filter.module-dbtng.patch9.01 KBdropcube
#6 filter.module-1.patch9.31 KBcsevb10
#4 filter.module-1.patch9.3 KBcsevb10
#2 394146_filter_dbtng.patch11.43 KBksenzee

Comments

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Title: convert filter module to DBTNG » DBTNG filter.module
Issue tags: +dc2009 code sprint

Standardizing title with all the other dbtng conversion issues.

ksenzee’s picture

ksenzee
she/her
commented
Status: Active » Needs review
StatusFileSize
new 394146_filter_dbtng.patch11.43 KB
Crell’s picture

Crell commented
Status: Needs review » Needs work 
+  $format = db_query('SELECT * FROM {filter_format} WHERE format = :format', array(':format' => $format))->fetch();

That should be fetchObject() for better readability.

+    $formats = array(db_query("SELECT * FROM {filter_format} WHERE format = :format", array(':format' => $format))->fetch());

Ibid. There are a couple more of those as well.

csevb10’s picture

csevb10 commented
StatusFileSize
new filter.module-1.patch9.3 KB

Simple re-roll with the replacements suggested by Crell.

csevb10’s picture

csevb10 commented
Status: Needs work » Needs review

Changing status for review....

csevb10’s picture

csevb10 commented
StatusFileSize
new filter.module-1.patch9.31 KB

Fixed a missed reference.

dropcube’s picture

dropcube commented

Reviewed the patch, all db statements are converted... Seems RTBC.

dropcube’s picture

dropcube commented
StatusFileSize
new filter.module-dbtng.patch9.01 KB

Re-rolling the patch.

dries’s picture

dries commented
Status: Needs review » Fixed

Committed to CVS HEAD. Thanks!

Status: Fixed » Closed (fixed)
Issue tags: -DBTNG Conversion, -dc2009 code sprint

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +DBTNG Conversion, +dc2009 code sprint

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.