When you enter a log message for node revisions, the entry is not carried over to preview. Issue was that default value was not set on the form element.

CommentFileSizeAuthor
#5 394256_node_revlog_default_value_03.patch986 bytessenpai
#4 394256_node_revlog_default_value_02.patch3.77 KBcwgordon7
#2 394256_node_revlog_default_value.patch986 bytessenpai
node.pages-D6.patch427 bytesAnonymous (not verified)

Comments

senpai’s picture

senpai commented
Version: 6.9 » 7.x-dev
Assigned: Unassigned » senpai

Moving to 7.x-dev.

This logic flaw presented itself during the Documentation Sprint at Drupalcon D.C. while users were attempting to edit Handbook pages that now require a Log Message due to a drupalorg.module form alter. The string that a user entered into the log message did not propagate all the way through the form's validation and return due to the fact that there is no #default_value on the input element.

senpai’s picture

senpai commented
StatusFileSize
new 394256_node_revlog_default_value.patch986 bytes

Patch attached. Working on test for it right now.

Status: Needs review » Needs work

The last submitted patch failed testing.

cwgordon7’s picture

cwgordon7 commented
Status: Needs work » Needs review
StatusFileSize
new 394256_node_revlog_default_value_02.patch3.77 KB

Patch with test attached. There was some very very very weird stuff going on in the node preview test, so I added comments in the attempt to spare the next person attempting to debug these tests. ;)

senpai’s picture

senpai commented
StatusFileSize
new 394256_node_revlog_default_value_03.patch986 bytes

Here's a backport for D6 too, since this problem only rears it's angry head on d.o

Status: Needs review » Needs work

The last submitted patch failed testing.

cwgordon7’s picture

cwgordon7 commented
Status: Needs work » Needs review

The "latest" test patch was for d6, so it's understandable that it didn't apply against HEAD, so marking back to needs review.

senpai’s picture

senpai commented
Title: Node form does not have defaut value for revision_information - log » Node form does not have default value for revision_information log

Bumping, and fixing a mis-spelling in the title.

desbeers’s picture

desbeers commented
Status: Needs review » Fixed

This is fixed in #385602: Log message is lost on node preview Patch in that issue is committed to HEAD and has a patch attached now for Drupal 6.

senpai’s picture

senpai commented

Woo hoo! Forward Progress FTW! Thanks for the info, desbeers.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.