DBTNG: OpenID Module

Working on this now.

Relatively straight forward port of openID to DB-TNG. There aren't any tests written for this module yet but I tested it manually with two of my openIDs and everything seems to work.

Changing category to task. It was probably marked as a bug by mistake?

Just looks like a missed comma after 'openid':

$query = db_insert('authmap')
      ->fields(array('uid', 'authname', 'module'))
      ->values(array(
        'uid' => $account->uid,
        'authname' => $identity,
        'module' => 'openid'
      ))
      ->execute();

and I'd suggest breaking this into multiple lines:

$authname = db_query('SELECT authname FROM {authmap} WHERE uid = :uid AND aid = :aid', array(':uid' => $account->uid, ':aid' => $aid))->fetchField();

Everything else looks good and passes tests, and the rest looks good to me. I re-rolled the patch with those mods. Only line I'm not sure about (and maybe you know) is this line:

$authname = db_query('SELECT authname FROM {authmap} WHERE uid = :uid AND aid = :aid', array(
    ':uid' => $account->uid, 
    ':aid' => $aid,
  ))
  ->fetchField();

I'm not sure if that's the completely correct formatting.

Dangit. My fault. I should have caught that.

And updating status...

Ah, that seems obvious now, thanks!

No code changes, just a new re-roll against HEAD since the files changed.

Removed trailing whitespace after 1 statement.

FYI, there are automated tests for OpenID awaiting review in #251245: openid.module needs tests.

Looks good to me too. Committed to CVS HEAD. Thanks!

We had a regression in http://cvs.drupal.org/viewvc.py/drupal/drupal/modules/openid/openid.page...

Went from:

  db_query("DELETE FROM {authmap} WHERE uid = %d AND aid = %d AND module = 'openid'", $form_state['#args'][0]->uid, $form_state['#args'][1]);
  if (db_affected_rows()) {
    drupal_set_message(t('OpenID deleted.'));
  }
  $form_state['#redirect'] = 'user/'. $form_state['#args'][0]->uid .'/openid';

To:

function openid_user_delete_form_submit(&$form_state, $form_values) {
  $query = db_delete('authmap')
    ->condition('uid', $form_state['#parameters'][2]->uid)
    ->condition('aid', $form_state['#parameters'][3])
    ->execute();
  if ($query) {
    drupal_set_message(t('OpenID deleted.'));
  }
  $form_state['#redirect'] = 'user/'. $form_state['#args'][0]->uid .'/openid';
}

Note that $form_state['#args'] regressed back to $form_state['#parameters']. Also, we lost the condition 'module' = 'openid'. New query does not respect that.

It would appear that we have also lost the 'Code needs Review' state on d.org. :)

Good catch, and this definitely needs to be updated. In light of the missing needs review and reviewed states, how do we get this pushed?

I'm also seeing that

function openid_user_delete_form($form_state, $account, $aid = 0) {
  $authname = db_query('SELECT authname FROM {authmap} WHERE uid = :uid AND aid = :aid', array(
    ':uid' => $account->uid,
    ':aid' => $aid,
  ))
  ->fetchField();
  return confirm_form(array(), t('Are you sure you want to delete the OpenID %authname for %user?', array('%authname' => $authname, '%user' => $account->name)), 'user/'. $account->uid .'/openid');
}

Should add a condition of 'module' = 'openid' as well. Since openid_user_delete_form_submit() uses the condition, and the condition is also used in openid_user_identities():

    $query = db_insert('authmap')
      ->fields(array(
        'uid' => $account->uid,
        'authname' => $identity,
        'module' => 'openid',
      ))
      ->execute();

Guess we'll have to wait until the issue statuses come back.

There we go.

Everything looks good to me on the changes. I'll try and review the patch again to see if there were any other lingering issues like that.

Committed to CVS HEAD. Thanks!