This needs conversion.

Comments

ksenzee’s picture

Assigned: Unassigned » ksenzee

I'll take a stab at this.

ksenzee’s picture

StatusFileSize
new6.67 KB

In two places, I've broken out a one-line if(db_result(db_query(...))) into

$path_in_use = db_query(...)->fetchField();
if ($path_in_use) {
  ...
}

With the new DB syntax, queries are just plain longer than they used to be, and they need to be broken out onto multiple lines. But breaking this into multiple lines while leaving it inside the if clause just felt wrong. Plus it was really hard to read. Assigning it to a variable is more self-documenting.

ksenzee’s picture

Status: Active » Needs review

One of these days I'm going to actually comb through the project module issue queue, to figure out why my status changes don't stick.

berdir’s picture

Status: Needs review » Needs work

The indentation of the insert and some select queries is wrong, see the examples at http://drupal.org/node/310079.

berdir’s picture

Status: Needs work » Needs review
StatusFileSize
new7.88 KB

Re-roll....

dries’s picture

Status: Needs review » Fixed

Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)
Issue tags: -DBTNG Conversion

Automatically closed -- issue fixed for 2 weeks with no activity.