Posted by Crell on March 7, 2009 at 8:07pm
| Project: | Drupal core |
| Version: | 7.x-dev |
| Component: | path.module |
| Category: | task |
| Priority: | normal |
| Assigned: | ksenzee |
| Status: | closed (fixed) |
| Issue tags: | DBTNG Conversion |
Issue Summary
This needs conversion.
| Project: | Drupal core |
| Version: | 7.x-dev |
| Component: | path.module |
| Category: | task |
| Priority: | normal |
| Assigned: | ksenzee |
| Status: | closed (fixed) |
| Issue tags: | DBTNG Conversion |
This needs conversion.
Comments
#1
I'll take a stab at this.
#2
In two places, I've broken out a one-line if(db_result(db_query(...))) into
$path_in_use = db_query(...)->fetchField();if ($path_in_use) {
...
}
With the new DB syntax, queries are just plain longer than they used to be, and they need to be broken out onto multiple lines. But breaking this into multiple lines while leaving it inside the
ifclause just felt wrong. Plus it was really hard to read. Assigning it to a variable is more self-documenting.#3
One of these days I'm going to actually comb through the project module issue queue, to figure out why my status changes don't stick.
#4
The indentation of the insert and some select queries is wrong, see the examples at http://drupal.org/node/310079.
#5
Re-roll....
#6
Committed to CVS HEAD. Thanks.
#7
Automatically closed -- issue fixed for 2 weeks with no activity.