Closed (fixed)
Project:
Drupal core
Version:
7.x-dev
Component:
path.module
Priority:
Normal
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
7 Mar 2009 at 20:07 UTC
Updated:
3 Jan 2014 at 00:07 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
ksenzeeI'll take a stab at this.
Comment #2
ksenzeeIn two places, I've broken out a one-line if(db_result(db_query(...))) into
With the new DB syntax, queries are just plain longer than they used to be, and they need to be broken out onto multiple lines. But breaking this into multiple lines while leaving it inside the
ifclause just felt wrong. Plus it was really hard to read. Assigning it to a variable is more self-documenting.Comment #3
ksenzeeOne of these days I'm going to actually comb through the project module issue queue, to figure out why my status changes don't stick.
Comment #4
berdirThe indentation of the insert and some select queries is wrong, see the examples at http://drupal.org/node/310079.
Comment #5
berdirRe-roll....
Comment #6
dries commentedCommitted to CVS HEAD. Thanks.