Closed (fixed)
Project:
Drupal core
Version:
7.x-dev
Component:
documentation
Priority:
Normal
Category:
Bug report
Assigned:
Issue tags:
Reporter:
Created:
7 Mar 2009 at 20:19 UTC
Updated:
3 Jan 2014 at 00:07 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
jhodgdonComment #2
cwgordon7 commentedTagging this "novice" because it's a relatively easy issue that will serve as a nice introduction to the Drupal patch process. Basically, the required steps are:
- Checkout Drupal HEAD (see http://drupal.org/node/320)
- Take the contents out of modules/menu/menu.api.php
- Move them to modules/system/system.api.php
- Properly organize/alphabetize them with the other system functions.
- Create a patch (see http://drupal.org/patch/create)
- Upload the patch to this issue in a followup
You can always ask here or on IRC (see http://drupal.org/irc) for help if you need it.
Comment #3
BruceBGordon commentedTaking this task.
Comment #4
BruceBGordon commentedRemoved the file and moved changes as per spec above.
Comment #6
BruceBGordon commentedBug in infrastructure exposed by this patch which attempts to remove a file. Hopefully fixed by now. Marking as needs review.
Comment #8
dave reidRemarking as needs review since the PIFR issue with deleted files has been resolved, I think.
Comment #10
cwgordon7 commentedWondering if this has been fixed yet, and there's one easy way to test...
Comment #14
aspilicious commentedI tried this, dunno if it is still relevant.
Comment #15
aspilicious commentedComment #16
jhodgdonHmmm.
I looked into all of the hooks currently in menu.api.php. Most are definitely invoked from menu.inc and not menu.module, so yes those should be moved to system.api.php
But it looks like hook_menu_insert, hook_menu_update, and hook_menu_delete are only fired from menu.module, so they should probably stay in menu.api.php -- see http://api.drupal.org/api/function/menu_save/7 and http://api.drupal.org/api/function/menu_delete/7
Comment #17
jhodgdonAlso those hooks that are currently in menu.api.php and moving to system.api.php need to be added to the "menu" group/topic, if they are not already, using
@addtogroup menu
Comment #18
aspilicious commentedNot sure if I understand it entirely...
Let's try it...
Comment #19
cwgordon7 commentedWhy did you switch the group from "hooks" to "menu"?
Comment #20
cwgordon7 commentedTo clarify, the "hooks" group should still be used even if you're going to add the new group "menu".
Comment #21
aspilicious commentedhmmm can you use both at the same time?
* @addtogroup hooks
* @addtogroup menu
* @{
* @} End of "addtogroup menu".
* @} End of "addtogroup hooks".
Comment #22
cwgordon7 commentedActually I don't know why it would be in the "menu" group at all. We currently don't appear to list hooks in their conceptual topics (e.g. hook_form_alter() is not referred to as in the forms group.)
Comment #23
aspilicious commentedjhodgdon ping ;)
Comment #24
jhodgdonSorry, I don't tend to work much on weekends. Too busy having a real life. :)
- I agree with cwgordon that they should be in the hooks group.
- I also think the menu hooks should be in the menu group, or at least hook_menu() should be, but that's open for debate.
- I am not sure if addtogroup works with {}. You can just add it in the individual function doc header.
Comment #25
aspilicious commentedtry this
Comment #26
jhodgdonAssuming the test bot agrees, let's get this one in. It simply moves the existing doc to the right file.
Comment #27
webchickMakes sense to me. Committed to HEAD. Thanks! :)