DBTNG: Statistics module

I need to learn DBTNG anyway, so I've started this one..

It has some tricky parts in it, so I might have to ping you on IRC.

Attached is a first patch, some notes..

- there is only a single insert query and because of that, there is only a single place where delay() can be used
- I followed the newly proposed style for extenders at #425872: DX problem with DB extenders
- That module has *a lot* complex queries with functions, group by, custom count queries and unfortunatly, not so many tests. All queries seem to work but someone with more experience with DBTNG needs to review them carefully :)
- Is there a rule when to use dynamic and when static queries? I converted all calls to dynamic queries but there are a few simple queries that should maybe be static ones.

Ok.

Converted 3 queries or so back to static. Everything else in that module uses Pager.

Updated based on Crell's feedback at #394476-1: DBTNG: Menu module: Converted all db_*() calls which have more than one chained method call to multi-line.

I don't see any explanation so far in the issue as to why we're adding ->delay() to this query:

-    db_insert('accesslog')->fields(array(
-      'title' => strip_tags(drupal_get_title()),
-      'path' => $_GET['q'],
-      'url' => $_SERVER['HTTP_REFERER'],
-      'hostname' => ip_address(),
-      'uid' => $user->uid,
-      'sid' => session_id(),
-      'timer' => (int) timer_read('page'),
-      'timestamp' => REQUEST_TIME,
-    ))->execute();
+    db_insert('accesslog')
+      ->fields(array(
+        'title' => strip_tags(drupal_get_title()),
+        'path' => $_GET['q'],
+        'url' => $_SERVER['HTTP_REFERER'],
+        'hostname' => ip_address(),
+        'uid' => $user->uid,
+        'sid' => session_id(),
+        'timer' => (int) timer_read('page'),
+        'timestamp' => REQUEST_TIME,
+      ))
+      ->delay()
+      ->execute();

Double check the coding standards, there are multiple instances of foreach(...) instead of foreach (...). There should always be a space between control structures and their expressions.

Hm. I added the delay() call because Crell mentioned it and I thought that it does make sense. However, after reading http://dev.mysql.com/doc/refman/5.1/en/insert-delayed.html, I'm not so sure anymore..

- It's not supported for InnoDB
- It's actually slower than a normal INSERT, especially when the table is not in use. According to the documentation, you should only use it on a table where you run *very* long SELECT/UPDATE
- I've no idea how it's handled by other DBMS (if at all)

Because of that, I removed it again. Coding style corrections (compared to the examples at http://drupal.org/node/310079) are still part of that patch

Another changes:
- fixed the foreach's
- fixed the query in statistics_title_list, that was broken in many ways ;)

#160226: SQL in statistics_node_tracker function is wrong should imho be re-rolled after this gets in.

There is still something wrong with the statistics_title_list query, need to resolve that first.

I have to use range() instead of Pager and limit() as the blocks don't use a pager...

I reviewed this patch and it looked good to me so I committed it to CVS HEAD. We can re-open the issue if necessary.

Thanks Berdir!

so this should be marked as fixed :)