what about version for Drupal 6.x?

CommentFileSizeAuthor
#9 term_merge_d6.patch10 KBbleen

Comments

Steff Vanhaverbeke’s picture

I'm also looking for this kind of functionality on Drupal 6.
How about it?

eli’s picture

Status: Active » Postponed

We only use Drupal 5 right now, so I'm afraid this is pretty far down my To Do list. However, if you want to take a crack at porting it, I'd be glad to help.

asb’s picture

Hi,

I'm also looking for a D6 version. Currently, the "Taxonomy Manager" module might be an option (thus this is a great module it's a bit less comfortable than the "Term Merge" link).

Greetings, -asb

eli’s picture

Assigned: Unassigned » eli
Status: Postponed » Active

Ok, I did a quick & dirty Drupal 6 version. Please let me know if you encounter any bugs.

eli’s picture

Version: 5.x-1.1 » 6.x-1.x-dev
giorgio79’s picture

I get "page not found" when clicking on merge term link in term edit page.

giorgio79’s picture

This might help
http://drupal.org/project/deadwood

d5 to d6 converter :)

Gabriel R.’s picture

I tried it on my installation of D6, got a nice

Fatal error: Call to undefined function _taxonomy_access_get_nodes_for_term() in /usr/www/users/danb007/beta/sites/all/modules/taxonomy_access/taxonomy_access.module on line 253

No luck.

bleen’s picture

StatusFileSize
new10 KB

I've been doing some work with this module for D6 ...

The attached path includes the following:

  • ~ 85% is simple housekeeping (http://drupal.org/coding-standards).
  • I removed the term_merge_merge function and called drupal_get_form directly from the hook_menu page callback
  • I converted term_merge_merge_form_submit to use taxanomy_save_term
  • I removed bug where synonyms might end up duplicated
  • I made the success message a bit more informative ... but left in "Have a nice day!"

I'm sure I'll have some more updates to this, and I'll probably want to update this module for D7 at some point ... looking for a D6/D7 maintainer? Please let me know.

bleen’s picture

Assigned: eli » bleen
Status: Active » Needs review

I've recently been made a comaintainer for this module and I'd love to get at least one or two more people to take a look at this patch (#9) before I commit it. Any takers?

cyberwolf’s picture

Subscribing.

bleen’s picture

testers? anyone? anyone?

xurizaemon’s picture

Status: Needs review » Needs work

Some thoughts on D6-6.x-1.x-dev after a brief (not extensive) test -

  • The 'merge' link appears at the top of my term edit form. Seems out of place being above the title.
  • The 'merge' link text is "Merge this term into another another" which should probably be "Merge this term with another"
  • Merging terms says "The terms have been merged. Have a great day.". This should just say "The terms have been merged".*
  • Might want to test in conjunction with Taxonomy Image module. When merging terms, I see,
    • Not deleted from the files table because it is use on -1 other terms.
    • image removed.
  • Should use the admin/* path so as to remain in admin theme when viewing the merge term page.
  • Did you mean to offer a "Merge term" link on the term delete page?

* IMO introducing out-of-context chattiness detracts from the message in Drupal's admittedly already busy UI. Keep it simple and businesslike, no need to confuse the UI with irrelevant personal messages.

nylin’s picture

Status: Needs work » Closed (duplicate)

Marking this as closed (won't fix) until there is someone willing to continue the work of the 6.x release.

asb’s picture

Status: Closed (duplicate) » Closed (won't fix)
nylin’s picture

Woops :)

yarroha’s picture

Status: Closed (won't fix) » Needs work

Hi all,
As D6-6.x-1.x-dev doesn't work I've completely rewrote the module for my needs.
Maybe somebody will also need it.
You can find the code on GitHub: https://github.com/yarroha/term_merge

asb’s picture

@yarroha: Thanks for your work! I tried the zipball from github; it shows up on the modules administration page, and it can be enabled without throwing errors. However, no "Merge term" link shows up on my term edit pages.

(My task: I have hundreds of duplicate terms that were created by the broken 'content_taxonomy' module from contrib. Neither 'content_taxonomy' will be fixed, nor is there any other methode above direct database manipulations to accomplish this on D6 :-(

asb’s picture

@yarroha: Thanks for your work! I tried the zipball from github; it shows up on the modules administration page, and it can be enabled without throwing errors. However, no "Merge term" link shows up on my term edit pages.

(My task: I have hundreds of duplicate terms that were created by the broken 'content_taxonomy' module from contrib. Neither 'content_taxonomy' will be fixed, nor is there any other methode above direct database manipulations to accomplish this on D6 :-(

yarroha’s picture

@asb You should open this page http://sitename.com/admin/content/term_merge, choose vocabularies and start merge terms.
I will create a readme.txt file for this module and put this information there.

Work directly with database is not safe in this case. Because if You use some additional modules which works with taxonomy and content (http://drupal.org/project/field_taxonomy for example) You can easily broke something.

asb’s picture

Thanks, Yaroslav; I tried that, and indeed it works as you described it.

However, like in 'Taxonomy Manager', the duplicate terms are not listed in the "Select the term which should be moved" / "Destination term" dropdown menus. It seems, that Content Taxonomy did exactly what you forcasted for direct database operations: It broke a lot. For reference: Related issues are:

As it appears, this is just another total Drupal fuckup where contributed modules break Drupal's data structures in a way that is de facto unfixable (except for deleting all duplicates, one by one, at ./admin/content/taxonomy/3, and stop using modules like 'content taxonomy' (currrently listed with 30,302 installations) :-( It's not the fault of 'term_merge' that it can not repair this desaster.

eiland’s picture

The module from @yarroha worked fine for me, also with retaining (sub-)sub-categories. It forgot only the parent category while merging subcategories, but that was easily restored manually.

The officially listed 6.x-1.x-dev module forgot all about the sub-categories, and I believe they even got lost, thanks for the backup suggestion :)

bucefal91’s picture

Issue summary: View changes
Status: Needs work » Closed (outdated)

Guys, this is probably a dead issue. I am going to close it.