This is minor and nit picky but the state/province collection field when set to required: * is pushed to next line causing unexpected spacing between fields.

A single space is probably needed between the field itself and the label.

Comments

vm’s picture

Version: 6.x-3.1-rc1 » 6.x-3.x-dev
yesct’s picture

yesct’s picture

marked #424494: Default CSS label width as a duplicate of this. it has a css solution that might be useful.

brownlady09’s picture

Assigned: Unassigned » brownlady09
Category: bug » task
Status: Active » Needs work

THis is the first time I will be doing maintenance to Drupal web pages. How do I reduce the lines from sub-topic to the listed items. I noticed it always leave 2 lines spacing between the topic and the listed items.

vm’s picture

Assigned: brownlady09 » Unassigned
Category: task » bug
Status: Needs work » Active

why on earth would you shift this issue to you? mark it as needs work and change it to a task?

What exactly does your issue have to do with the issue as explained here?

Your question sounds better suited for the forums but will require far more explanation on your part.

mattyoung’s picture

Issue tags: -location bdragon consider commit
StatusFileSize
new1.49 KB

Here is a patch

1) widen the label width, I use 10em instead of px unit.

2) remove the .location input {"float: left"; }. It's causing the "Current coordinate" fieldset to budding up against the right end of the Postal code field instead of moving down below it. It's also causing the line space of all the input fields to be narrower than normal.

3) Add a class attribute to the "Current coordinate" fieldset and set its with to 36em so it's uniform in width to all the other fields.

mattyoung’s picture

Status: Active » Needs review
StatusFileSize
new1.5 KB

Same patch as last one but change the input field width to 25em instead of px unit. Now everything line up perfectly.

yesct’s picture

tagging.

yesct’s picture

mattyoung did you edit something in your #6 comment above?
just to clarify, which patch should we look at? #6 or #7?

mattyoung’s picture

#7

yesct’s picture

Status: Needs review » Reviewed & tested by the community
StatusFileSize
new79.38 KB
new157.44 KB
new15.93 KB
new45.41 KB
new77.07 KB
new27.57 KB
new50 KB
new1.25 KB

works great. tested it with small fonts and large fonts.
rerolled to take out the extra tab and convert the tab to spaces.
screen shots attached.

bdragon’s picture

Component: Code » User interface
Priority: Minor » Normal

Does this look fine in other themes too?
(I agree that the I7 picture does look good.)

yesct’s picture

StatusFileSize
new71.86 KB
new59.66 KB
new63.48 KB
new107.49 KB
new72.59 KB
new92.86 KB
new120.21 KB
new86.35 KB

it looks good, I tried it with the various D6 core themes and fusion, acquia marina, zero point and zen. I tried it zooming in and out (making font smaller and larger using browser View menu in firefox). I also check in Safari and Google Chrome.

rooby’s picture

Status: Reviewed & tested by the community » Fixed

Committed to D6 & HEAD branches.
Not required for D5.

Thanks for all the testing.

yesct’s picture

rooby’s picture

Just realised I was looking at the DRUPAL-5 branch instead of the DRUPAL-5--3 branch :(

Committed to DRUPAL-5--3 - http://drupal.org/cvs?commit=372112

Automatically closed -- issue fixed for 2 weeks with no activity.