Hi!

Following the info on the main page about upgrading, I downloaded the 4.6.4 build and installed it by uploading and replacing all files in

includes/
modules/
index.php
cron.php

(settings.php are not different than 4.6.3)

Up until then I had 4.6.3, I have custom theme, running phptemplate. Non-core modules: flexinode, poormanscron, gsitemap. I did not execute update.php, as the security notice said there was no update to database or API. Should I have launched it?

And yet, ever since I've updated, the statistics module seems to be broken. For example, when I click to referers, I get page rendered alright. By default it is ordered by number of hits. This is what sort-by-last-visit url is:

www.example.com/admin/logs/referrers?sort=asc&order=Last+visit

And when I click it, the page reorders, but the same url is this:

www.example.com/admin/logs/referrers?sort=asc&order=Last+visit&order... visit

(I've copied link from Firefox -- rightclick + copy link location -- and pasted here as is)

Actually, all links on the referers page get the query entities doubled and broken.

Please help me. Did I do something wrong?

Comments

CoR-1’s picture

Actually, all links on the referers page get the query entities doubled and broken.

What I mean is all "command" links, for column ordering, get broken. Links in the list of referrers are ok, except that '&' are replaced with '&'. I am not sure if that should be that way.

CoR-1’s picture

I found what happened, actually.

All '&' are recoded as '&', not only in statistics module, but wherever ampersand appears in an url, and if it is passed through url again (by click on the same), the '&' gets recoded again so it is now '&', and so on, with each click.

??!

laura s’s picture

_____ ____ ___ __ _ _
Laura Scott :: design » blog » tweet

nathandigriz’s picture

This &amp is the xhtml compliant version of & it should not make any difference in the urls function unless drupal messing with it in the htaccess and it is getting malformed.

rjung’s picture

In a related vein, I think this may also be affecting Drupal's theme_table() column sort order -- after upgrading to 4.6.4, I can no longer click on a table's header to change the ascending/descending sort by that field. The anchor to re-sort the table doesn't look correct:

http://www.example.net/admin/logs/referrers?sort=asc&order=Last+visit&order=Last%20visit&order=Last%20visit&order=Hits&order=Url&order=Last%20visit&order=Last%20visit&order=Last%20visit&order=Last%20visit&order=Last%20visit

--R.J.
http://www.electric-escape.net/

--R.J.

CoR-1’s picture

Look at &. It's the same problem. Wherever Drupal creates internal url with these amps, they get recoded wrong, and in case of sort order URLs, subsequent clicks would multiply amps, as described in my post.

So, apparently that's not because of something I did wrong with installation.

Where do we submit an issue?

:)

rjung’s picture

http://drupal.org/project/issues, under "Drupal".

I'm a tad surprised the thread that announced the security updates and patches doesn't allow us to post replies to it. Seems to make more sense that way, IMO.

--R.J.
http://www.electric-escape.net/

--R.J.

nathandigriz’s picture

That usually leads to a 200+ commented thread and to the bugs and bad usability associated with long threads at drupal.org. I am glad you can't post there.

psicomante’s picture

i have the same problem...

URL malformed:

image1.html&size=_original
?q=comment/reply/432&quote=1432&quote=1
?q=admin/logs/referrers&sort=asc&order=Url

DOH! What can i do?

EDIT: i've seen the issue. sorry.
BlogForum

rjung’s picture

Just to close the thread, I'm pretty sure the problem is fixed here.

--R.J.
http://www.electric-escape.net/

--R.J.

CoR-1’s picture

Yes, yes, that's true. Sorry, I was too busy, I forgot about this thread. :)