syslog module: General cleanup and bugfix

I forgot to mention that. The patch was made outside of the Drupal root because of lack of CVS access. You will need to apply it using p1, IIRC.

Need to add OS X to the paragraph about UNIX/Linux.

Follow-up patch. OS X is now mentioned as well.

The headings are wrong in Garland, since the help topic should be a <h1>.

This patch fixes a bug in system_watchdog() that caused a PHP error if the hook was invoked for the first time.

I suggest we change this as well:

function syslog_facility_list() {
  return array(
    LOG_LOCAL0 => t('LOG_LOCAL0 - Local 0'),
    LOG_LOCAL1 => t('LOG_LOCAL1 - Local 1'),
    LOG_LOCAL2 => t('LOG_LOCAL2 - Local 2'),
    LOG_LOCAL3 => t('LOG_LOCAL3 - Local 3'),
    LOG_LOCAL4 => t('LOG_LOCAL4 - Local 4'),
    LOG_LOCAL5 => t('LOG_LOCAL5 - Local 5'),
    LOG_LOCAL6 => t('LOG_LOCAL6 - Local 6'),
    LOG_LOCAL7 => t('LOG_LOCAL7 - Local 7'),
  );
}
function syslog_facility_list() {
  return array(
    LOG_LOCAL0 => 'LOG_LOCAL0',
    LOG_LOCAL1 => 'LOG_LOCAL1',
    LOG_LOCAL2 => 'LOG_LOCAL2',
    LOG_LOCAL3 => 'LOG_LOCAL3',
    LOG_LOCAL4 => 'LOG_LOCAL4',
    LOG_LOCAL5 => 'LOG_LOCAL5',
    LOG_LOCAL6 => 'LOG_LOCAL6',
    LOG_LOCAL7 => 'LOG_LOCAL7',
  );
}

The strings we have now don't add anything to the codes themselves.

Tagging this WTF because Windows users should *not* be able to select Linux facilities.

What about http://www.linuxmanpages.com/man2/syslog.2.php?