Viewing issues of a project without activating Project releases gives php error [#396056]

Comment	File	Size	Author
#2	project_release_dependency.patch	954 bytes	marcp

Comment #1

subcomandante commented 9 March 2009 at 15:00

And if I enable the "Project releases" module without creating any release it seems to work.

Log in or register to post comments

Comment #2

marcp commented 21 March 2009 at 22:23

Status:

Active

» Patch (to be ported)

Status	File	Size
new	project_release_dependency.patch	954 bytes

Not sure if we really want a module_exists() call in a project_issue views handler, but this tiny patch fixes the problem and gets rid of the dependency.

Log in or register to post comments

Comment #3

dww

we/he/they

commented 23 March 2009 at 18:12

Status:

Patch (to be ported)

» Needs review

(what needs to be ported here?)

Yes, I have a nearly identical patch on my laptop. ;) Until we have a real solution for #75565: make a hook to get version options for a given project and #239485: attach an issue queue to any node type. I think calling module_exists() like that is about the best we can hope for. This field (and filter) is already smart about hiding itself when there are no version options for a given project (e.g. for http://drupal.org/project/issues/infrastructure) so I think it's fine to just add brains in here that if project_release isn't enabled, there are never any versions for issues. Better to put the conditional logic here than into the default views themselves, etc.

I'll probably commit this (or something like it) soon, but I need to look a little closer.

Log in or register to post comments

Comment #4

marcp commented 23 March 2009 at 18:43

Yeah, I never saw the field/filter, so it seemed pretty safe to just module_exists() it out.

Sorry about the "(to be ported)" -- that was the first time I'd seen the new status choices and it was the only one with the word "patch" in it. I figured that you'd set me straight!

Log in or register to post comments

Comment #5

AmrMostafa commented 13 April 2009 at 15:55

subscribe

Log in or register to post comments

Comment #6

aclight commented 19 April 2009 at 15:04

#438262: Project release dependency has been marked as a duplicate of this issue.

Log in or register to post comments

Comment #7

dww

we/he/they

commented 22 April 2009 at 17:25

Status:

Needs review

» Fixed

After further review and testing, committed #2 to HEAD. Thanks folks, and sorry for the delay.

Log in or register to post comments

Comment #8

marcp commented 22 April 2009 at 17:47

No, Derek -- thank YOU!

It's good to see us getting closer to a 6.x release. The project_issue page still mentions a dependence on Views 6.x-2.x-dev, but that's probably not still the case.

Probably not the right place to ask this, but what remains before a 6.x release of project/project_issue?

Log in or register to post comments

Comment #9

dww

we/he/they

commented 22 April 2009 at 18:28

@marcp: Funny you should ask ;) #439958: Document issues left before 6.x official release

Thanks for the reminder about the project page -- I just fixed that to mention views 6.x-2.5 which is the current requirement. I also added a link to #439958 there...