Many people have complained that users cannot access event finder options when viewing event nodes directly. To solve this event finder module should create a block and have it support viewing event finder info when viewing event nodes normally and through the event finder search interface.

CommentFileSizeAuthor
#12 ef_t.diff761 bytesZack Rosen
#11 ef_t.diff.dif761 bytesZack Rosen
#10 ef.diff.511.1 KBZack Rosen
#5 ef.diff.48.94 KBZack Rosen
#4 EventFinderOptionBlock.png51.57 KBZack Rosen
#3 ef.diff.34.69 KBZack Rosen
#2 ef.diff.24.46 KBZack Rosen
#1 ef.txt3.93 KBZack Rosen

Comments

Zack Rosen’s picture

Zack Rosen commented
StatusFileSize
new ef.txt3.93 KB

Here is my first cut as a patch.

* moved event finder information out of the node body and into a block.
* made the block accessible when viewing event nodes normally and through event finder's interface

I also fixed a couple interface bugs

* made it 'volunteer module aware' - links to volunteer for the event show in the event finder info block when applicable
* added a link in event finder block to "Login to register for this event" when event finder registration is set to "one click" and the node is being viewed by an anonomous user.

Zack Rosen’s picture

Zack Rosen commented
StatusFileSize
new ef.diff.24.46 KB

Oops. Forgot to remove the now deprecated ef_display_opts setting from event finder settings. Try this patch instead.

Zack Rosen’s picture

Zack Rosen commented
StatusFileSize
new ef.diff.34.69 KB

Fixed bug that caused wrong registration link to show for users who were logged in and wanted to register.

Zack Rosen’s picture

Zack Rosen commented
StatusFileSize
new EventFinderOptionBlock.png51.57 KB

For those without patch-foo here is a screenshot

Zack Rosen’s picture

Zack Rosen commented
StatusFileSize
new ef.diff.48.94 KB

Now with correct .diff format and better link text standardization

Zack Rosen’s picture

Zack Rosen commented
Status: Active » Needs review

oh yah...

leoklein’s picture

leoklein commented

This is a great addition. I always thought that the reformatting of Event Details in EventFinder -- reformatting from the normal Detail view -- is a usability issue.

My only thought, is that it's nice to have these options in a Block but is that how other modules achieve the same end? Consistency is this area just makes things a whole lot easier to manage.

Anonymous’s picture

Anonymous (not verified) commented

Hey - How about patches that do not break current functionality?

I have eventfinder deployed on a ton of sites and have no plan on including eventfinder options in a block. In some cases, we are not even using blocks on the event pages.

M

Zack Rosen’s picture

Zack Rosen commented

patachon: wrt consistancy - putting options in a block is how organic groups and CiviCRM handle this problem. It let's site designers have control over where the controls are positioned and what they look like.

techsoldaten: ok, i'll reroll the patch to make it a configuration option:

Show Event Finder Options
(*) In a block
( ) Above event content
( ) Below event content

Zack Rosen’s picture

Zack Rosen commented
Title: Move EventFinder options into a block » Updated patch w/ configurable block
StatusFileSize
new ef.diff.511.1 KB

Here is an updated version of the pack that makes the event finder options configurable to display above the node body, below the node body, or in a block.

Zack Rosen’s picture

Zack Rosen commented
Title: Updated patch w/ configurable block » this patch requires a new themable function
StatusFileSize
new ef_t.diff.dif761 bytes
Zack Rosen’s picture

Zack Rosen commented
Title: this patch requires a new themable function » Themable function
StatusFileSize
new ef_t.diff761 bytes

Needed to create a new themable function for my patch. Here it is.

Zack Rosen’s picture

Zack Rosen commented
Title: Themable function » Make EventFinder controls accessible on event nodes and in blocks
Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Fixed

Patches applied.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)