Closed (fixed)
Project:
Ubercart
Version:
5.x-1.7
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
9 Mar 2009 at 19:27 UTC
Updated:
12 Dec 2009 at 18:28 UTC
Jump to comment: Most recent file
See these two issues on ubercart.org:
http://www.ubercart.org/issue/9558/shipping_quote_message_text_does_not_...
http://www.ubercart.org/forum/support/8921/cannot_change_shipping_quote_...
In summary, custom messages entered in the form at admin/store/settings/quotes/edit do not get saved when the form is submitted.
The cause is that some D6-specific code got inserted into uc_quote.module for Ubercart 1.x (D5). In particular, $form_state, a D6 form variable, was being used instead of $form_value. The attached patch fixes this.
I searched the rest of the UC 1.7 codebase, and didn't find any other instances of this problem.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | condizioni.png | 32.36 KB | Scorpio26 |
| uc_quote.module.patch | 1.19 KB | tr |
Comments
Comment #1
3cwebdev commentedThe patch works perfect, thanks!
Comment #2
Island Usurper commentedGlad to hear there aren't any other problems. It's already fixed in the dev version, but thanks for providing a patch until the next release. I must have forgotten to do that when I fixed it.
Comment #4
Scorpio26 commentedI use the uc_quote.module.patch and It works
My problem now is how to translate the text put in admin/store/settings/quotes/edit : "Shipping quote error message" in the other languages of my shop.
tanks
Comment #5
marcoBauli commentedShipping quote messages can be saved to any like, but they cannot be translated as Scorpio26 says... i'll reopen this instead of creating a new issue as localization should be probably supported. Please just tell if a new issue would address this better. Thx!
Comment #6
tr commentedNo, please don't reopen this. The original report was a bug in the Drupal 5 version of Ubercart, and it was fixed long ago. Post a new issue if you want to discuss translation issues in Drupal 6.