Core doesn't use _ in URL's (admin/settings/site-information).

Let's change

admin/settings/openid_provider
to
admin/settings/openid-provider

and

user/%user/openid_sites
to
user/%user/openid-sites

CommentFileSizeAuthor
#6 396468_dashes_1.patch2.24 KBaron novak
#2 396468_dashes.patch1.81 KBalex_b
#1 396468_dashes.patch1.06 KBalex_b

Comments

alex_b’s picture

alex_b commented
Status: Active » Needs review
StatusFileSize
new 396468_dashes.patch1.06 KB
alex_b’s picture

alex_b commented
StatusFileSize
new 396468_dashes.patch1.81 KB

And while I'm at it: some empty lines between menu path definitions contained white spaces, some not - removed the empty lines from hook_menu().

alex_b’s picture

alex_b commented
Assigned: alex_b » Unassigned
anarcat’s picture

anarcat commented
Priority: Normal » Minor

Patch fails to apply on D6 branch:

anarcat@homere:/var/alternc/html/r/root/drupal/drupal-6.6/sites/all/modules/openid_provider$ patch < 396468_dashes_0.patch 
patching file openid_provider.module
Hunk #5 FAILED at 39.
Hunk #6 succeeded at 58 (offset 10 lines).
1 out of 6 hunks FAILED -- saving rejects to file openid_provider.module.rej
anarcat’s picture

anarcat commented
Status: Needs review » Patch (to be ported)
aron novak’s picture

aron novak
Primary language Hungarian
Location Hungary, Budapest
commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new 396468_dashes_1.patch2.24 KB

Here is a rerolled patch.

anarcat’s picture

anarcat commented
Status: Needs review » Reviewed & tested by the community

Excellent, works. Note that it conflicts with #313848: Add section on admin page.

walkah’s picture

walkah commented
Status: Reviewed & tested by the community » Fixed

Committed, thanks guys :-)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.