Don't use underscores in URLs
alex_b - March 9, 2009 - 20:27
| Project: | OpenID Provider |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | minor |
| Assigned: | Unassigned |
| Status: | reviewed & tested by the community |
Description
Core doesn't use _ in URL's (admin/settings/site-information).
Let's change
admin/settings/openid_provider
to
admin/settings/openid-provider
and
user/%user/openid_sites
to
user/%user/openid-sites
#1
#2
And while I'm at it: some empty lines between menu path definitions contained white spaces, some not - removed the empty lines from hook_menu().
#3
#4
Patch fails to apply on D6 branch:
anarcat@homere:/var/alternc/html/r/root/drupal/drupal-6.6/sites/all/modules/openid_provider$ patch < 396468_dashes_0.patchpatching file openid_provider.module
Hunk #5 FAILED at 39.
Hunk #6 succeeded at 58 (offset 10 lines).
1 out of 6 hunks FAILED -- saving rejects to file openid_provider.module.rej
#5
#6
Here is a rerolled patch.
#7
Excellent, works. Note that it conflicts with #313848: Add section on admin page.