Hi there!
I´m recently trying up this module and I love it already! It´s just terrific the easy way that you can select your users to subscribe, according to your group.
I would like to know if can be done (or is it planned, or could be added...) some of these features:
1. The possibility for individual users to set inside their profiles if they want to be part of the "team" (even if they actually are members of the OG group).
2. The possibility to set all team member checkboxes, to "checked" by default.
Again, this module is fantastic. Thanks!!
Rosamunda
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | 396666_9_team.patch | 1.68 KB | David Goode |
| #5 | notifications_team.396666.v3.patch | 2.5 KB | cfennell |
| #3 | notifications_team.396666.v2.patch | 1.88 KB | cfennell |
| #2 | notifications_team.396666.patch | 1.86 KB | cfennell |
Comments
Comment #1
Rosamunda commentedMeybe instead of "all checked by default" it could have a checkbox that allows to "check them all"?
Comment #2
cfennell commentedI needed a "checkall" option for a project that I'm working on. Here's an untested patch that does something similar; I'm sure the JS could be golfed a bit.
Comment #3
cfennell commentedJust occurred to me that I was focused only on node forms, so my selector was a bit too specific. Changed that...
Comment #4
cfennell commentedOk, this is obviously a work in progress ;^), I don't update the hidden form value to reflect the checkall action in the above patches - I'll post something when I've done that.
Comment #5
cfennell commentedOk, now the hidden "edit-notifications-team-selected" form element is updated when checkall is triggered. I also adopted some of the coding conventions of the module maintainer and was reminded of JQuery's "removeClass/addClass" functions as well, very handy. Anyway, it looks like this is going to work for my little project. Good luck on yours.
Comment #6
cfennell commentedChanging the status - not saying this should go in as-is, but some form of a "check all" feature would be great. Thanks.
Comment #7
David Goode commentedHey all, I'll look at this shortly.
David
Comment #8
saveriuccio commented@libsys,
I've just applied your patch and seems isn't working fine for me.. I'm really really interested on this feature.
Any suggestion?
Comment #9
David Goode commentedHey! I found a bit of a bug where it can add duplicate numbers/not remove items from the hidden form entry upon unchecking "check all." I fixed that by making the code simpler & just reusing the existing click() method. At this point I think the JS is fine, the only thing I'd like to see before committing this might be an option on the settings page for showing the check all button -- for now you could just make it a sitewide variable like the # of checkboxes setting. That settings page looked a little empty anyways :-). I'd disable it by default so people don't get any surprise functionality upon upgrading--otherwise known as bugs :-) Once that's done I'd be happy to commit, thanks for the work so far!
David
Comment #10
David Goode commentedOh, also might be nice if you added a handler so that when everything was checked manually, check all would get checked automatically. That might be confusing though...either way, not required to be committed, but something to think about.
David