This patch fixes a bug where the taxonomy help as defined in admin » taxonomy is ignored.
When a taxonomy term has the flag tags on, we call a special autfill form. The help with that form is now hardcoded.

This patch fixes that.

CommentFileSizeAuthor
#14 _39672_vidhelp.patch956 bytesmorbus iff
#11 taxonomy_autocomplete_help_2.patch1.56 KBBèr Kessels
#10 taxonomy_help_3.png4.32 KBBèr Kessels
#9 taxonomy_help_2.png7.21 KBBèr Kessels
#8 taxonomy_help_1.png25.16 KBBèr Kessels
#4 taxonomy_autocomplete_help_1_0.patch1.33 KBBèr Kessels
taxonomy_autocomplete_help_1.patch1.33 KBBèr Kessels

Comments

Bèr Kessels’s picture

Bèr Kessels commented

bump

Bèr Kessels’s picture

Bèr Kessels commented
Version: x.y.z » 4.7.0-beta1
Tobias Maier’s picture

Tobias Maier commented

+1 for the patch in general.

but please take a look at the atached file
it is made in the false way
your patched file was seen as the original and the real (unpatched) file as the patched one...
so please reroll the patch, thanks

Bèr Kessels’s picture

Bèr Kessels commented
StatusFileSize
new taxonomy_autocomplete_help_1_0.patch1.33 KB

other way around

dries’s picture

dries commented

I don't understand the problem. What do you mean with 'ignored'? How can I reproduce this?

Tobias Maier’s picture

Tobias Maier commented

he wants that this help text gets printed (if available) insteade of this hardcoded help-text

Bèr Kessels’s picture

Bèr Kessels commented

@dries:

in the "add vocabulary" screen, one has the ability to add a "custom help text". Currently for freetagging vocs, that help text never shows up, instead a hardcoded one shows. Its either this patch, to let it show up everywhere. Or its removing that help-text thing from the interface/database.

Bèr Kessels’s picture

Bèr Kessels commented
StatusFileSize
new taxonomy_help_1.png25.16 KB

First, let me explain in three screenshots what the *bug* is.

Bèr Kessels’s picture

Bèr Kessels commented
StatusFileSize
new taxonomy_help_2.png7.21 KB

and you see, the text, does *not* appear here.

Bèr Kessels’s picture

Bèr Kessels commented
StatusFileSize
new taxonomy_help_3.png4.32 KB

After the patch, can mak my own help texts, like it should be.

Bèr Kessels’s picture

Bèr Kessels commented
StatusFileSize
new taxonomy_autocomplete_help_2.patch1.56 KB

And now an updated patch.

dries’s picture

dries commented
Status: Needs review » Fixed

Committed to HEAD.

raema’s picture

raema commented
Status: Fixed » Closed (fixed)
morbus iff’s picture

morbus iff
they/them
commented
Version: 4.7.0-beta1 » 4.6.5
Status: Closed (fixed) » Needs review
StatusFileSize
new _39672_vidhelp.patch956 bytes

There's a convoluted bug where a freetag's $help (per this patch) can be used for the $help of a non-freetagging vocabulary, depending on weight, loop order, and blah blah blah. This one-liner just uses the standard vocabulary->help for non-freetags.

Bèr Kessels’s picture

Bèr Kessels commented
Status: Needs review » Reviewed & tested by the community

I can confirm the bug, and have tested the patch. It works as advertised.

morbus iff’s picture

morbus iff
they/them
commented
Version: 4.6.5 » x.y.z
dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to HEAD. Thanks.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)