The theming information available in the UI must be LTR, since it displays only english words (php function names).

This patches addresses it, however more work is needed on this. We should add a css-class to it, and foce also different padding/margin since it overflows to the right.

IMHO, we should first appy the patch from #360710: RTL CSS files then, this patch, and only then fixing the CSS. As a person using views2, I can live with a small overflow as displayed on this image, and fix it later in a next release. But I do need these 2 patches, otherwise my head will explode.

k10xby!

CommentFileSizeAuthor
#4 ui-translated.jpg61.84 KBiamjon
views2-theme-is-ltr.patch6.97 KBelcuco
views2-hebrew-theme-ltr.jpeg153.98 KBelcuco

Comments

tombigel’s picture

tombigel commented

@elcuco: You really think it should be addressed with specific code?

Maybe we should take a little more global approach across all the modules we make RTL patches to -

For example we can decide on a specific css class name to give to all the elements that must stay LTR and add a line in the CSS to address them all in the *-ltr.css files we create, something like:

.keep-element-ltr{direction:ltr;text-align:left}

I think in the long run it will be much more readable and maintainable.

esmerel’s picture

esmerel commented
Status: Active » Postponed (maintainer needs more info)

I'd also say "Is this really a views problem, or a Drupal Core issue?" Because if Drupal core does it differently than Views, that's one thing, but if views is following core, then core needs to decide to make that change also.

esmerel’s picture

esmerel commented
Category: bug » feature
Status: Postponed (maintainer needs more info) » Postponed

This really needs some attention from someone who is a theming/LTR-RTL expert. I hesitate to close it, but the Views maintainers don't really have the expertise to fix this appropriately. If someone with that expertise wants to take this up, that would be fantastic. Given that, I'm going to postpone it.

iamjon’s picture

iamjon commented
Status: Postponed » Closed (won't fix)
StatusFileSize
new ui-translated.jpg61.84 KB

Hi eluco, thank you for you enthusiasm for the patches. I brought up this issue at the drupal dojo tel aviv.
It might just be easier to translate the interface. Please see the screenshot of my partly translated interface. I can post it/patch if you still think it is necessary.

I'm marking this as closed, workaround offered.