In OpenX 2.6 "Site - Variable" has been added as an option to filter ads. It would be great to expose vocabularies (either by name or id) to OpenX by providing this variable.

Comments

gordon’s picture

Version: 6.x-1.0 » 6.x-1.x-dev
Status: Active » Fixed

This has been implemented in the latest updates.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

danieltnbaker’s picture

Status: Closed (fixed) » Needs work

The last update did not completely fix this issue.

It does not take into account multiple terms associated with the node.

Also tokens do not work for the site - variable 'name' field.

Both I think are pretty useful features which would benefit the module?

gcybill’s picture

Considering that OpenX is only a module to show ads from OpenX, this issue could be worked on both OpenX and OpenX Manager module.

It would be great if the OpenX Manager could export drupal data to the ads server as variable (for example: "d_taxonomy_<taxo_name>"), while OpenX filter ads shown based on the variable.

mropanen’s picture

There is a bug in at least 7.x-1.2: in openx.inc, around lines 40-44 (I think, I fiddled with the file a bit) there's

$node = menu_get_object('node');
      
if (isset($node)) {
  $objects['node'] = $node;
}

which I think should be setting $data['node'] = $node; instead.

andy.s.clark’s picture

Title: Node tokens not being replaced - Patch attached. » Taxonomy / Site Variable
Version: 7.x-1.x-dev » 6.x-1.x-dev
Component: Code » Miscellaneous
Assigned: mavimo » Unassigned
Category: bug » feature
Priority: Major » Normal
Status: Reviewed & tested by the community » Needs work
Issue tags: -backport
StatusFileSize
new340 bytes

Confirmed and created D7 patch for fix in comment #5.

jm.federico’s picture

Title: Taxonomy / Site Variable » Node tokens not being replaced - Patch attached.
Status: Needs work » Reviewed & tested by the community

Reaaally need this.

Tested and works!

Also, changing title to reflect what patch does.

Cheers

mavimo’s picture

StatusFileSize
new340 bytes

Patch to D7

mavimo’s picture

Version: 6.x-1.x-dev » 7.x-1.x-dev
Component: Miscellaneous » Code
Assigned: Unassigned » mavimo
Category: feature » bug
Priority: Normal » Major
Issue tags: +backport

Status: Needs work » Reviewed & tested by the community
wuinfo - bill wu’s picture

Version: 6.x-1.x-dev » 7.x-1.x-dev
Issue summary: View changes

Repeat #9

wuinfo - bill wu’s picture

Status: Reviewed & tested by the community » Fixed

Commited and pushed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.