Download & Extend
Popups: Add and Reference » Issues

Append to #prefix and #suffix instead of overwrite

Posted by cYu on March 10, 2009 at 7:03pm
Project:Popups: Add and Reference
Version:6.x-2.0-alpha1
Component:Code
Category:bug report
Priority:minor
Assigned:starbow
Status:needs review

Issue Summary

In case other modules are altering the #prefix and #suffix of an element, this patch will concatenate the needed divs.

AttachmentSize
prefix_suffix.patch1.09 KB
Login or register to post comments

Comments

#1

Posted by starbow on March 10, 2009 at 10:59pm
Assigned to:Anonymous» starbow

Seems like a good idea.

#2

Posted by e2thex on March 23, 2009 at 3:16pm

I think this might correct http://drupal.org/node/388458

#3

Posted by starbow on March 23, 2009 at 6:30pm

Drat, I should have rolled this into 1.0. I will aim to get it into 1.1

#4

Posted by cYu on March 27, 2009 at 1:55pm
Status:needs review» closed (duplicate)

This is rolled into a different patch #388406: multiple values nodereference field

#5

Posted by cYu on March 30, 2009 at 8:38pm
Status:closed (duplicate)» needs review

Un-duping with hopes that this simple patch can get in without the other code involved with the issue this was originally considered a dupe of. See http://drupal.org/node/388406#comment-1418308

#6

Posted by cYu on May 19, 2009 at 1:35pm
Category:feature request» bug report

Marking as a bug since 2 different issues report that this may fix existing problems.

#7

Posted by greg.harvey on May 19, 2009 at 5:49pm

Just tried the patch posted here:
http://drupal.org/node/388406#comment-1603308

Didn't work. =(

The "Add another item" button worked, but the "Add New: Content Type" link vanished. Doh!

#8

Posted by greg.harvey on May 20, 2009 at 2:24pm
Status:needs review» reviewed & tested by the community

Correction, that patch *did* work. =)

It's practically identical to the one in this issue as well. Someone might want to review both before deciding which "style" to include. But anyway, works.

My problem was a different bug. If you use a view to populate your CCK node reference field instead of the default mechanism then the "add content type" link won't appear - I had this issue and it threw me off.

So for now, reviewed and tested by at least one person! Is this already in the dev snapshot because of another patch? Is someone somewhere else killing kittens?? =P

#9

Posted by ezra-g on May 31, 2009 at 4:58am

Patch no longer applied to 6.x-2.0 release. Here it is re-rolled.

AttachmentSize
397614.patch 1.01 KB

#10

Posted by cYu on June 1, 2009 at 1:24pm
Status:reviewed & tested by the community» needs work

The re-rolled patch is missing the concat for #prefix.

#11

Posted by cYu on June 11, 2009 at 3:16pm
Version:6.x-1.x-dev» 6.x-2.0-alpha1
Status:needs work» reviewed & tested by the community

Here is a re-rolled patch for the 2 branch.

AttachmentSize
prefix_suffix.patch 1.1 KB

#12

Posted by starbow on June 25, 2009 at 10:49pm

@cYu: thanks for the patch
I am going though my patch list and putting the patches to review in an external todo list, so hopefully I will be keepting track of things better (fingers crossed :)

#13

Posted by taz88ny on September 24, 2009 at 7:31pm
Status:reviewed & tested by the community» needs review

The current patch appends to prefix and suffix instead of overwriting, but the "Add New..." link disappears when clicking on the "Add another item" button for node reference fields.

I've attached a patch that fixes that by adding the popup wrapper before the prefix, and adding the "Add New..." link after the suffix. The will allow the node reference form to rebuild and not remove the "Add New..." link.

- Luis

AttachmentSize
patch_397614.patch 996 bytes

#14

Posted by _Jay on June 23, 2011 at 2:38pm

Did you get these patches to work? After trying #11 and #13 patches I still can't see "Add New:" link when I put the field in multigroup. Could the problem be with my CCK version? Anyone have this working?

Popups: Add & Reference : 6.x-2.0-alpha1
CCK: 6.x-3.0-alpha3