The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.Not all comments in aggregator.test follow the Drupal doxygen formatting conventions. This is getting in the way of improvements to aggregator.test, let's fix it.
Most importantly
* There should not be pseudo type definitions like @param object $feed, but @param $feed
* The description of a @param should be in a new line indented by 2 characters and it should explain what the type of the parameter is.
An example of an incorrect format would be AggregatorTestCase::deleteFeed(). An example of a correct format would be AggregatorTestCase::createFeed().
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | jamesan_397800-3.patch | 2.37 KB | JamesAn |
| #4 | jamesan_397800-2.patch | 2.43 KB | JamesAn |
| #2 | jamesan_397800.patch | 2.37 KB | JamesAn |
Comments
Comment #1
alex_b commentedThis is a Novice task.
Comment #2
JamesAn commentedI've combed through the comments and reformatted some of the comments to comply with the conventions. I think I've caught them all.
Comment #3
alex_b commentedJames - end all comments with a period (e. g. TRUE if feed is unique). Otherwise this looks great as far as I can tell.
Comment #4
JamesAn commentedThanks for catching that. Someone else told me that today too.. ^^" I'll remember it this time! That comment 'TRUE if feed is unique' appears to be the only comment without a terminating period.
Comment #5
alex_b commentedNice work. Ready to be committed.
Comment #7
JamesAn commentedOops. Uploaded the wrong one.. without the period. Don't know why it failed though. Let's try again.. ^^"
Comment #8
JamesAn commentedI think the manual editting problem started after I finished working on #228477: Sinhala language in Drupal. I set my text editor to 16-bit Unicode encoding to deal with the Sinhala native characters and UTF-16-encoded patches don't seem to work. But it did with #228477. I don't know. Ah well.. At least it passes here.
Comment #9
dries commentedCommitted to CVS. Thanks.