install_taxonomy_get_tid() needs to search by vid

DamienMcKenna - March 11, 2009 - 03:17
Project:Install Profile API
Version:6.x-2.0
Component:CRUD functions and includes
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

Due to the fact that multiple vocabularies can have the same term name, install_taxonomy_get_tid() really needs to limit the query to vid.

#1

DamienMcKenna - March 11, 2009 - 03:29
Status:active» needs review

PLEASE IGNORE.
I mixed up two issues, will post this to a separate issue.

AttachmentSize
install_profile_api-n398022-taxonomy_tid_fix.patch 987 bytes

#2

DamienMcKenna - March 11, 2009 - 03:33
Status:needs review» active

Please ignore the previous attachment, it was for the wrong issue.

#3

DamienMcKenna - March 11, 2009 - 04:01
Status:active» needs review

The attached patch limits install_taxonomy_get_tid() to the vid if passed in through the optional argument.

#4

DamienMcKenna - March 11, 2009 - 04:01

Patch actually attached this time.

AttachmentSize
install_profile_api-n398022-get_tid_vid.patch 956 bytes

#5

James Andres - May 29, 2009 - 23:13

Seems sensible to me, committing with a small change (keeping vid numeric, as done in taxonomy.module with optional arguments).

AttachmentSize
install_profile_api-n398022-get_tid_vid_v2.patch 920 bytes

#6

James Andres - May 29, 2009 - 23:25
Status:needs review» fixed

#7

System Message - June 12, 2009 - 23:30
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.