By sl27257 on

Hi,

I noticed that the function valid_input_data() disappeared when moving from 4.5.5 to 4.5.6. I was using this in a module I have written myself. The only solution I have found so far was to remove these calls. As I do not see anything on this on the support pages, what do I have to think of when I remove these validation calls? Do I have to add the validation somewhere else?

/Thomas

⋅ Categories: Drupal 4.5.x or older

Comments

fax8’s picture

fax8 commented

function valid_input_data() has silently disappeard from 4.6.4 too.
I also had my modules broken for this...
I'm still looking for a replacement..

Fabio

----
My websites adrenalinteam.it - windsmpeg.tk - falcoarredamenti.it

Steven’s picture

Steven commented

There is no replacement because the concept of valid_input_data() was flawed. There is no magical check you can perform that will separate safe from unsafe data. It depends on what happens to the data and how it is output.

The guidelines about text handling still stand.

--
If you have a problem, please search before posting a question.

sl27257’s picture

sl27257
Location Stockholm
commented

Unfortunately "guidelines about text handling" is not fully valid for 4.5.x or 4.6.x. The function check_markup does only exist in HEAD (4.7.x) so that can not be used.

More Unfortunately: I have not dared to upgrade to 4.6 yet as some of the modules I am using seem to give major problems when upgrading. Especially "image" and "event" are important for me.

So in a way I have reached a dead end...

--
Thomas

--
Thomas

hexa’s picture

hexa commented

how did u solve this problem, since i have the same.

sl27257’s picture

sl27257
Location Stockholm
commented

I had to rewrite the modules using parts of the "guidelines about text handling" mentioned above.

  $content.=t('<strong>Visiting address</strong>: %data',
            array('%data' => check_plain($node->visiting_city)));

Basically I am checking the entered text when outputting it instead of at input.

Regarding the "event" problem I made a mirror of the main site and did all the upgrading on this one first.

--
Thomas

--
Thomas