Change 'Workflow settings' to 'Default publishing options' in Content type editing UI

Here's a patch for this. I changed the text to "Publishing settings" to keep consistent with the other fieldsets on that form (Submission form settings, display settings, etc).

Changing status to CNR

Oh yes - good one.

Since on the create content form this is called "Publishing options," should we should probably make the fieldset on the content types page consistent.

good point. here's a patch (398068.002.patch) with the text on the "Content Types" page set to "Publishing Options"

although now that I look at the node/add form, maybe it should be "Publishing settings" there as well? We have Revision Information, Comment Settings, URL path settings, Author Information and Publishing Options. Options is the only one that doesn't fit...

So I'm also attaching another patch (398068.003.patch) that changes it to Publishing Settings everywhere. I feel like that makes more sense, but I don't know really know...

changing status to needs review.

I like the second idea better due to the consistency argument. But they both look good.

Sounds good, indeed RTBC.

tag

   $form['options'] = array(
     '#type' => 'fieldset',
     '#access' => user_access('administer nodes'),
-    '#title' => t('Publishing options'),
+    '#title' => t('Publishing settings'),

To get this committed, please create a separate issue requesting that $form['options'] needs to be renamed.

'options' was a weird form array key before already. Now it's completely off-the-wall, because not even the fieldset title matches 'options'.

Committed 398068.002.patch from #8. Thanks!

Marking this 'code needs work' so we can continue our conversation about naming.