Make aggregator array keys lower case

To clarify - what needs to be done is to change all the keys of the $item array to lowercase?

So, for example, change

    if (!empty($item['TITLE'])) {
      $item['TITLE'] = $item['TITLE'];
    }

to

    if (!empty($item['title'])) {
      $item['title'] = $item['title'];
    }

Is that all?

This patch makes all the uppercase keys in function aggregator_parse_feed() in aggregator.parse.inc lowercase. The goal is to then be able to simplify the aggregator_save_item() function.

I wasn't sure of a couple of uppercase items which I changed - see attached screenshot for the two lines I'm talking about. Let me know if I shouldn't have changed these.

thanks alex_b

I've rerolled the patch to remove uppercase keys from aggregator.parser.inc and now also from aggregator.processor.inc too.

I did find this a bit tricky, and it's my first multiple file patch.

There are some keys in a comment at the top of function hook_aggregator_parse() in aggregator.api.php which I did not change as I wasn't sure:

 *   Recognized keys:
 *   TITLE (string) - the title of a feed item
 *   DESCRIPTION (string) - the description (body text) of a feed item
 *   TIMESTAMP (UNIX timestamp) - the feed item's published time as UNIX timestamp
 *   AUTHOR (string) - the feed item's author
 *   GUID (string) - RSS/Atom global unique identifier
 *   LINK (string) - the feed item's URL
 *
 * @see hook_aggregator_parse_info()
 * @see hook_aggregator_fetch()
 * @see hook_aggregator_process()
 *
 * @ingroup aggregator
 */
function hook_aggregator_parse($feed) {

I also found and left the following, because I wasn't sure, in aggregator.admin.inc function _aggregator_parse_opml()

the keys: OUTLINE, XMLURL, TEXT and OUTLINE (not sure if this one's a key?)

function _aggregator_parse_opml($opml) {
  $feeds = array();
  $xml_parser = drupal_xml_parser_create($opml);
  if (xml_parse_into_struct($xml_parser, $opml, $values)) {
    foreach ($values as $entry) {
      if ($entry['tag'] == 'OUTLINE' && isset($entry['attributes'])) {
        $item = $entry['attributes'];
        if (!empty($item['XMLURL']) && !empty($item['TEXT'])) {
          $feeds[] = array('title' => $item['TEXT'], 'url' => $item['XMLURL']);
        }
      }
    }
  }
  xml_parser_free($xml_parser);

  return $feeds;
}

Nice work!
Well, only one line was needed to get the things work.
In fact you need to convert the uppercase string to lowercase before examining.

I thought this patch is a easy patch so it could be one to get my feet wet with patch reviewing...

- aplyed the patch run simple tests on the agreator module (no error)
- added some feeds to my site which got parsed without error
- I read the patch and it is indeed just changing case of the keys
- got nothing from coder module

I don't know if that is sufficent for a "reviewed & tested by the community.

so I'd love to get feedback how I did reviewing this patch

spuky

since I got no feedback i am setting this one to rtbc

still not shure if my review is sufficent

spuky

Committed to CVS HEAD. Thanks!