As the title says. It might be nice to add a feed.module to Drupal that consolidates all feed-related info in one place, so that this can be toggled for different types of nodes all in one place.

CommentFileSizeAuthor
#10 feeds_1.patch10.27 KBwalkah
#9 feeds_0.patch10.27 KBwalkah
#6 feeds.patch10.25 KBwalkah
#5 node-feed-length.patch3.95 KBwalkah
#2 node_4.module70.01 KBBoris Mann
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Boris Mann’s picture

Boris Mann CreditAttribution: Boris Mann commented
Title: Admin option to toggle between teaser and full text in RSS feeds » Admin option to toggle between headline, teaser, and full text in RSS feeds
Component: other » node.module

I love the fact that this has been active forever :P

One day we will have a feed.module to rule them all...

Boris Mann’s picture

Boris Mann CreditAttribution: Boris Mann commented
Priority: Normal » Critical
Status: Active » Needs review
FileSize
node_4.module70.01 KB

What the heck, let's make this critical. Google launched blogsearch today -- it reads feeds, so if you're not outputting full feeds, it means Google's not indexing everything you put out.

Attached is an updated node.module which sets options for this, as well as includes an option for RSS or Atom feeds (but doesn't implement this yet). If someone could refactor and turn into a patch, we could still get this into 4.7.

Dries’s picture

Dries CreditAttribution: Dries commented

Would this be your first core patch? ;)

Boris Mann’s picture

Boris Mann CreditAttribution: Boris Mann commented

It would/will be if I were better at rolling patches against HEAD and didn't stuff so much stuff into it...

...back to non-coding work.

walkah’s picture

walkah CreditAttribution: walkah commented
FileSize
node-feed-length.patch3.95 KB

so, Boris is a wimp... but this is a pretty cool feature. attached is a re-worked patch. all working 'n' stuff.

walkah’s picture

walkah CreditAttribution: walkah commented
FileSize
feeds.patch10.25 KB

at Dries' request - here's an updated patch (where I hereby admit to sneaking in some other things I'd wanted to do). Hopfeully it's worthy to be snuck in at the deadline. (it's even still the 15th in .be for another couple minutes).

So this patch does the following:

* adds a "feed settings" section to admin/settings where 2 new settings are introduced:
* number of items per feed
* default length of feed descriptions (title only, teaser, full)
* patches all of core to obey the above - including the new aggregator (out) feeds
* adds support for adding namespaces in _nodeapi('rss item') - which means things like iTunes RSS and yahoo's media rss can be implemented by the appropriate modules (i.e. audio.module)
* includes some additional info in the default node feed - specifically the element (links directly to comments) - and dc:creator - to show node author information.

sepeck’s picture

sepeck CreditAttribution: sepeck commented

+1 on the features. This is one of those things that gets mentioned and or requested in the forums enough and I sure would like it.

walkah’s picture

walkah CreditAttribution: walkah commented

oh yeah, i forgot to mention one other little thing, that I think is nice... if you're using the teaser length (as is the default) it inserts a read more link in the description... which makes it obvious to your readers that there is more to the post :)

(and a good way to drive traffic back to your site, i suppose)

walkah’s picture

walkah CreditAttribution: walkah commented
Assigned: Unassigned » walkah
FileSize
feeds_0.patch10.27 KB

d'oh. cleaning up some little boo boos in that last version. should be commit ready now - if i may be so bold ;)

walkah’s picture

walkah CreditAttribution: walkah commented
FileSize
feeds_1.patch10.27 KB

ARGH! sorry for the spam, but nobody's gonna like array_merge'ing an array and a string. *sigh*

last one i promise.

m3avrck’s picture

m3avrck CreditAttribution: m3avrck commented

Patch applies cleanly and looks good to me. One little bug I found (not related to this patch but feeds in general so should be addressed), is that the top of my feeds I have

<title>user's blog</title>
<link>http://localhost/drupal_cvs/drupal/?q=blog/1</link>
<description/>

Note ... should be a space in there. Fix that bug with this patch and I'll get it a +1 ;)

Dries’s picture

Dries CreditAttribution: Dries commented

Committed to HEAD. Thanks. Please update the module upgrade notes so module author can take advantage of the new settings!

Boris Mann’s picture

Boris Mann CreditAttribution: Boris Mann commented
Status: Needs review » Fixed
faolcer’s picture

faolcer CreditAttribution: faolcer commented
Status: Fixed » Closed (fixed)