Allow opt-in during registration

I added an opt-in during registration checkbox to notify. Just a single checkbox that flips the master switch and content options to enabled.

The way I did it was to add the hook user function to notify, which puts serialized data in the user table: "notify_status"

Then I wrote another function which does a left join on the users and the notify tables, grabs all the uids that are not already present in the notify table, checks them in users for "notify_status" and, if the status is present, adds their records to the notify table. This function is triggered by notify_cron.

function _notify_optin(){
$result = db_query('SELECT DISTINCT(users.uid) FROM users LEFT JOIN notify on users.uid = notify.uid WHERE notify.uid IS NULL');
while ($uid = db_fetch_object($result)) {
$account = user_load(array('uid' => $uid->uid, 'status' => 1));
if ($account->notify_status) {

db_query('INSERT INTO {notify} (uid, status, node, teasers, comment) VALUES (%d, %d, %d, %d, %d)', $account->uid,1,1,0,0);
   }
 }
}

function notify_user($type, $edit, &$user, $category = NULL) {
  switch ($type) {
    case 'register':
      return array(array('title' => t('Notification settings'), 'data' => form_checkbox(t('Email notification'), 'notify_status', 1, $edit['notify_status'], t('Receive daily email notifications of new content posted to this site.')), 'weight' => 3));
  }
}

function notify_cron() {
   _notify_optin();
...

So, when cron runs, anybody who opted in during registration gets added to notify. If they've already changed their notify settings before cron runs, they are ignored. Maybe there's a better way to do this. Any suggestions?

Also, I couldn't figure out how to remove the notify switch from the user table after it has been checked, although that really doesn't affect the functionality.

Maybe there's a better way to do this with far less code:

function notify_user($type, $edit, &$user, $category = NULL) {
  switch ($type) {
    case 'register':
      return array(array('title' => t('Notification settings'), 'data' => form_checkbox(t('Content emailing'), 'notify_status', 1, $edit['notify_status'], t('Receive daily email notifications of new content posted to this site.')), 'weight' => 3));
    case 'insert':
      if ($edit['notify_status']) {
          db_query('INSERT INTO {notify} (uid, status, node, teasers, comment) VALUES (%d, %d, %d, %d, %d)', $user->uid,1,1,0,0);
      }
   }
}

This patch does several things. Some of the code was inspired by this: http://drupal.org/node/28040

1. admin interface:

a. limit notifications by node type;
b. Allow simple opt-in checkbox in user registration form;
1. If simple checkbox is enabled, set the default values for notifications enabled via user registration checkbox. Users can always change them later.

2. user interface
a. checkbox visible in user registration form.

This is a patch against 4.6.

here's screenshot of admin/notify