I have been at this for a few days...
followed the instructions to modify line 282 and it ended up looking like this

$result = pager_query(db_rewrite_sql("SELECT u.name, u.uid, count(dl.uid) AS linkcount FROM {delicious_user} du LEFT JOIN {users} u ON u.uid = du.uid LEFT JOIN {delicious_link} dl ON u.uid = dl.uid GROUP BY dl.uid ORDER BY u.name", 'du', 'delicious_user'), 20, $count_query="select count(distinct(uid)) from {delicious_user}");

is that right?
also added the code to line 916
so all together it looks like this

if ($list) {
      $output = theme('item_list', $list);
      $output .= theme('pager', NULL, $user->pagesize);
      $output = "<div class='node'><ul class=delicious_menuList id=delicious_menu_0>\n$output</ul>\n</div>";
      }

but still.. i get the following error on every page of my site if delicious is enabled.. and interestingly.. still on the admin/module page even if its disabled...????

user error: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 1
query: SELECT distinct(dl.description), dl.href FROM thefractal_delicious_link dl LEFT JOIN thefractal_delicious_tag dt ON dl.lid = dt.lid LEFT JOIN thefractal_users u ON dl.uid = u.uid ORDER BY dl.linktime desc LIMIT 0, in /home/jimboj/public_html/includes/database.mysql.inc on line 66.

user error: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 1
query: SELECT distinct(dl.description), dl.href FROM thefractal_delicious_link dl LEFT JOIN thefractal_delicious_tag dt ON dl.lid = dt.lid LEFT JOIN thefractal_users u ON dl.uid = u.uid ORDER BY dl.linktime desc LIMIT 0, in /home/jimboj/public_html/includes/database.mysql.inc on line 66.

I am running a multisite install with all sites sharing a the user tables...

really need this one working.
thanks
ryan grace.
www.thefractal.org

Comments

Veggieryan’s picture

So... i tried to add another block and now the previous error disappeared after a new error showed up:

user error: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ')' at line 1
query: INSERT INTO thefractal_delicious_block (dbid, title, users, tags, maxentries) VALUES (5, 'Delicious Bookmarks', '', '', ) in /home/jimboj/public_html/includes/database.mysql.inc on line 66.

warning: Cannot modify header information - headers already sent by (output started at /home/jimboj/public_html/includes/common.inc:384) in /home/jimboj/public_html/includes/common.inc on line 192.

even though i have uninstalled the module and dropped all the tables... it seems to remember that this is the fifth time i am adding a block overall?

hmm...
thanks,
ryan.

Veggieryan’s picture

well... it must have been something in my cache or ?

because i added another block WITH a user restriction and now its working!

if anyone else reads this... just keep clicking stuff and the module will start working.. dont give up.. ITS WORTH IT!

this is the COOLEST MODULE EVER!

now with this and flock.com i can bookmark to my blog with my browser...!
(you can also drag and drop your flickr photos into your blog...)

woa.
ryan.

merlinofchaos’s picture

Assigned: Unassigned » merlinofchaos
Status: Active » Fixed

Strange. I'm going to mark this as not a bug and hope that the weirdness was just a cache issue. I'm not completely convinced but hey, if it's working for you, great. Well, fixed since there isn't a 'not a bug' state.

Veggieryan’s picture

Status: Fixed » Active

wierd. it worked for a few days and then broke again...
strange...
i dropped the tables and reinstalled but i still get:

user error: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 1
query: SELECT distinct(dl.description), dl.href FROM thefractal_delicious_link dl LEFT JOIN thefractal_delicious_tag dt ON dl.lid = dt.lid LEFT JOIN thefractal_users u ON dl.uid = u.uid ORDER BY dl.linktime desc LIMIT 0, in /home/jimboj/public_html/includes/database.mysql.inc on line 66.

where should i start looking?

merlinofchaos’s picture

Ok, the problem there is lack of validation on user input data. In the block, the 'max entries' field is blank, which should cause you to just get an empty block, but instead causes this bug.

The immediate fix:

Change line 614 of delicious.module to:

  $result = db_query_range("SELECT distinct(dl.description), dl.href FROM {delicious_link} dl LEFT JOIN {delicious_tag} dt ON dl.lid = dt.lid LEFT JOIN {users} u ON dl.uid = u.uid $where ORDER BY dl.linktime desc", 0, intval($block->maxentries));

This leads me to believe your first problem is the same kind of thing, so I need to make sure data is properly validated.

merlinofchaos’s picture

Status: Active » Fixed

Fixed in HEAD. Sorry about the troubles!

Anonymous’s picture

Status: Fixed » Closed (fixed)