Closed (fixed)
Project:
Attachment
Version:
master
Component:
User interface
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
5 Dec 2005 at 04:25 UTC
Updated:
2 Mar 2006 at 05:30 UTC
Jump to comment: Most recent file
Comments
Comment #1
drewish commentedyeah, the drupal devs removed the hook_nodeapi 'form' op. the attached patch moves the functionality to a hook_alter_form() function.
i also had to make some changes to the attachment_form() function because it's now operating on the node at a less "fully formed" point.
Comment #2
drewish commentedI did some playing around and realized that it wasn't loading the existing files. Here's a patch that seems to work a little better.
After looking at some other parts of the module I realized cleaner change for attachment_form().
Comment #3
Ernie_ commentedcan someone post the module after patching ?
i can not run any patch
thks
Comment #4
Sartori commentedI've tried applying both patches - no error, but still no sign of any attachment options? :(
Comment #5
drupalxykon commentedyou decide which attachment module to use under configure node types
Comment #6
drewish commentedSartori, just to clarify what vrao said: after applying the second patch (to a clean copy of the attachment module), you'll need to go to admin/settings/content-types (if you're running a current version of CVS) and enable the attachment option. at that point, you should see an option in the node edit form.
i'd like to ask everyone, please test the patch i attached to comment #2 and leave feedback whether it worked for you or not.
Comment #7
graggrag commentedJust getting into this ... there seems to be a typo in line 23 that might account for the reports of the attachment option going missing. It uses '#default_value'=>variable_get('attachment_node_'. $node->type, 0), but $node doesn't exist at that code point.
Maybe change $node->type to simply $type?
Comment #8
drewish commentedgraggrag, good catch on that. I've attached an updated patch. Please test it out and make sure it works.
Comment #9
graggrag commentedHi, that one's cool I think, but overall it's still kinda funky. No, that's not an explicit bug report. First thing I noticed with today's cvs is that Add always reports 'No file selected' even though the file seems to process.
Comment #10
drewish commentedgraggrag, that sound like the same error reported by one of the users of my filemanager based module... would you mind describing the versions of software you're running, mainly Drupal and the webserver.
Comment #11
graggrag commentedApache/2.2.0, php-5.1.2, Drupal 4.7.0-beta4 and a cvs from today (both suffer).
Filemanager is cvs on 2006-01-24, shows 1.12 2006/01/16.
Comment #12
drewish commented[resetting the title. for what ever reason with the project module, when you set a comment's title it changes the issue's title]
graggrag, it might be easiest to try to debug this off thread. you don't have your contact tab enabled so maybe you could contact me instead?
Comment #13
ccourtne commentedThanks for the patch. I have applied it to my working tree and will check it in soon.
Comment #14
(not verified) commented