Merge in features from Restricted Search

deviantintegral - March 12, 2009 - 16:46
Project:Search config
Version:6.x-1.x-dev
Component:Miscellaneous
Category:task
Priority:normal
Assigned:Unassigned
Status:active
Description

Hi,

I'm the maintainer of the Restricted Search module. When I started that, Search Config didn't do anything related to hiding content from the search index, but now it allows hiding by type. The other feature which Restricted Search does is allow excluding individual nodes from the index, which I don't think Search Config can do. What would you think about 1) patches implementing this feature and 2) providing an upgrade path? If we can do that, I'd be really glad to help on getting a stable version of this module out for Drupal 6.

Thoughts?

#1

canen - March 14, 2009 - 06:08

I did a quick search for the restricted search module since the above link does not work. The search result brings back the correct information but actually links to the search_block module. I am too tired at the moment to try and figure out what's going on :)

Anyway, feel free to provide patches. I would love to see them. I am not actually comfortable with current method of preventing content type from being searched since they are only removed from the index _after_ .

#2

deviantintegral - April 8, 2009 - 16:17

@canen: Sorry, must have typo'ed the link - it is the "search_block" project: http://drupal.org/project/search_block. I renamed it as it was confusing before, but it's virtually impossible to change a module's short name.

The reason Restricted Search uses cron the way it does is to prevent any issues with module weights. What happens if search_config_update_index() get's called before node_update_index() (or some other contrib module)? I know the module could just set it's weight to be higher, but that's not really a great solution either.

#3

canen - April 8, 2009 - 19:19

I wasn't talking about how restricted search uses cron, I was talking about search config. Sorry for the misunderstanding. I actually haven't looked at the module yet.

#4

canen - April 8, 2009 - 19:35

I looked at the module and it has the same problem as search config. There doesn't seem to be an easy way to prevent nodes from being indexed. Jeff Eaton wrote an article on how something similar can be done using hook_db_rewrite_sql. It might be an option worth looking into.

#5

deviantintegral - October 9, 2009 - 16:13
Status:active» fixed

This has been done over at http://drupal.org/project/search_restrict, which I'm now using instead of my own module.

#6

izmeez - October 10, 2009 - 23:46

I am new to the search_config module and see this issue is now marked as fixed with a link to the search_restrict module.

This sounds good too me, but I am still a little unclear on the direction of this, the search_config module, having also read the readme file.

I think the way that search_config allows configuration of the advanced search feature is very useful.

As for affecting search results, I do not know if that is necessary or even desirable to include as it may impact adversely on other access control modules such as og or modules that do some access control such as support, etc. There are already several warnings that using combinations of access control modules may not work and may conflict so it may be advantageous to leave that out of this module.

Simply configuring the advanced search in a theme independent way is great for this contrib module. I think it would be great if the core search configuration included this.

I am happy to see the search_restrict is a separate module. I have not explored that module as I do not have an immediate need.

I hope these personal thoughts are useful for discussion.

Thanks,

Izzy

#7

Bartezz - October 12, 2009 - 14:51
Status:fixed» active

I've installed and tried search_restrict http://drupal.org/project/search_restrict (not restricted search AKA search_block)
But this also doesn't have the feature to exclude individual nodes from search either as restricted search AKA search_block does.

it would be great if this feature could be adapted into search_config.
So that maybe under 'Pulication-options' you could have a checkbox to disable the individual node from search.

What do you guys think?

Cheers

 
 

Drupal is a registered trademark of Dries Buytaert.