When adding a User permission, the User table is shown below the Roles area instead of the Users area. Everything seems to work, but the interface is a little off.

The User table is only shown in the wrong location after updating the permissions and BEFORE saving the term.

This happens in both IE7 & FF3.

Steps to reproduce:
1.) Start with a term with no permissions assigned.
2.) Edit the term
3.) Expand the permissions fieldset
4.) Add a user to the User text field
5.) Click 'Update Permissions'
6.) Re-Expand the permissions fieldset
7.) Notice the User table in the wrong location
8.) Click 'Save'
9.) Now edit the term again
10.) Expand the permissions fieldset again
11.) Notice the User table is now in the correct location.

CommentFileSizeAuthor
#2 399900_element_weights.patch1.51 KBdeviantintegral

Comments

deviantintegral’s picture

deviantintegral commented
Title: User table position is inconsistant » User table position is inconsistent
deviantintegral’s picture

deviantintegral commented
Status: Active » Needs review
StatusFileSize
new 399900_element_weights.patch1.51 KB

Here's a patch which provides for explicit weights for the fields. I'm not sure why they'd change on different loads of the same form, but this way the order should remain the same.

I also discovered that you lose other unsaved fields when you update permissions since the module itself doesn't expect to be changed in this manner. I'll open another issue for that.

arlinsandbulte’s picture

arlinsandbulte commented
Status: Needs review » Reviewed & tested by the community

Patch works for me.

deviantintegral’s picture

deviantintegral commented
Status: Reviewed & tested by the community » Fixed

Thanks for testing - I missed the email that this issue had been updated. Committed to HEAD.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.