A test at http://d-theme.com/rootcandy shows one HTML validation error and several CSS validation errors. CSS 3 validation produced 11 errors.

URI : http://d-theme.com/sites/all/themes/rootcandy/style.css?s
274 #content-wrap Value Error : width Parse Error document.body.clientWidth 782? "780px" : document.body.clientWidth > 1262? "1260px" : "99%")
548 input.form-submit, input.teaser-button Property -moz-border-radius doesn't exist : 4px
549 input.form-submit, input.teaser-button Property -moz-outline-radius doesn't exist : 4px
550 input.form-submit, input.teaser-button Property -webkit-border-radius doesn't exist : 4px
712 .pager li.pager-current, .pager li a Property -moz-border-radius-bottomleft doesn't exist : 2px
713 .pager li.pager-current, .pager li a Property -moz-border-radius-bottomright doesn't exist : 2px
714 .pager li.pager-current, .pager li a Property -moz-border-radius-topleft doesn't exist : 2px
715 .pager li.pager-current, .pager li a Property -moz-border-radius-topright doesn't exist : 2px
725 .pager li.pager-current, .pager li a Property -moz-border-radius doesn't exist : 4px
726 .pager li.pager-current, .pager li a Property -moz-outline-radius doesn't exist : 4px
727 .pager li.pager-current, .pager li a Property -webkit-border-radius doesn't exist : 4px

CSS 2.1 validation produced the same 11 errors plus one more.
4 html Property overflow-y doesn't exist in CSS level 2.1 but exists in [css3] : scroll

The XHTML 1.0 Strict validation failed due to the obsolete target element in the footer link and the following error. The class is not quoted.
<div id="navigation"><ul class = i>

CommentFileSizeAuthor
#3 rootcandy-remove-target.patch921 byteschriscohen

Comments

peterx’s picture

peterx commented
Version: 6.x-1.0-rc5 » 6.x-1.0
sign’s picture

sign commented
Priority: Normal » Minor
Status: Active » Closed (won't fix)

I like rounded corners for pagination and buttons in firefox, so I am fine with the css issues above.
The target attribute is ok with me as well. Don't want to add another js for handling window opening in a new window.
All those "errors" are not affecting the functionality (afaik) of how the theme should work so marking as won't fix.

Thank you for reporting!

chriscohen’s picture

chriscohen commented
StatusFileSize
new rootcandy-remove-target.patch921 bytes

The first CSS error is not related to proprietary browser properties. The browser-specific stuff isn't really a concern because it genuinely adds features until there is a standard way of doing this. You could fix the target attribute in the footer quite quickly using jQuery, by removing the target attribute and using rel="external" or similar. I've put together a patch but it's not tested I'm afraid.

sign’s picture

sign commented
Status: Closed (won't fix) » Active

thanks chris,
I'll test these lines and will add it in if its ok. Thanks!

And totally agree with you on css issues.

sign’s picture

sign commented
Version: 6.x-1.0 » 6.x-1.x-dev
Status: Active » Fixed

thanks guys, committed,
should be html valid now

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.