Allow exclamation in URL

Bump.

I got caught with this bug in CCK link module v5.x-2.5.

Example valid URL with exclamation:
http://www.usda.gov/wps/portal/!ut/p/_s.7_0_A/7_0_2KD?contentidonly=true...

Okay, I've fixed this for the next release of 6.x - but will need to also fix it in 5, I see.

Thanks for the example urls, folks.

Issue found in 6.x-2.6-beta1

Here is one more patch, to allow exclamation in query, to validate the following url: http://www.orbitz.com/App/PerformMDLPDealsContent?OSC=KPpjTzSlU0!-109580...

And one more character that should be allowed in query is ^

Valid URL example is http://clk.tradedoubler.com/click?p=60261&a=1741603&g=17066602&url=http:...|UK|TD|??|^^|&utm_source=TradeDoubler&utm_medium=Affiliate&utm_campaign=TradeDoubler&utm_term=&utm_content=

In addition, exclamation marks are also allowed in the anchor. Both Twitter and Facebook use url's like http://twitter.com/#!/marcvangend nowadays. In other words, this should be added to the patch:

--- link.module
+++ link.module
@@ -867,7 +867,7 @@
   $directories = "(\/[a-z0-9". $LINK_ICHARS ."_\-\.~+%=&,$'!():;*@\[\]]*)*";
   // Yes, four backslashes == a single backslash.
   $query = "(\/?\?([?a-z0-9". $LINK_ICHARS ."+_|\-\.\/\\\\%=&,$'():;*@\[\]{} ]*))";
-  $anchor = "(#[a-z0-9". $LINK_ICHARS ."_\-\.~+%=&,$'():;*@\[\]\/\?]*)";
+  $anchor = "(#[a-z0-9". $LINK_ICHARS ."_\-\.~+%=&,$'!():;*@\[\]\/\?]*)";
 
   // The rest of the path for a standard URL.
   $end = $directories .'?'. $query .'?'. $anchor .'?'.'$/i';

We've just discovered this limitation when trying to make use of the oEmbed module for our embed server. The embed server uses the #! notation in the same format as twitter, so I'm wondering how I can help get this implemented.

http://drupal.org/node/1238808