The current module appears to be broken, it's referencing $image->res when it should be referencing $image->resource.

Patch attached.

CommentFileSizeAuthor
#8 401694_imagecache_effects-res_to_resource.patch4.13 KBmathieu
#6 imagecache_effects-6.x-1.1__patched__imageapi.tar_.gz2.73 KBosman
#4 Patched version of imageapi.inc2.87 KBadamcarsonb
imagecache_effects-res_to_resource.patch4.13 KBdeciphered

Comments

burgs’s picture

burgs commented
Status: Needs review » Reviewed & tested by the community

Yeah, this module is useless without this patch.

jjjames’s picture

jjjames commented

Good find. An update would be great :)

alextronic’s picture

alextronic commented

THANK YOU SIR

I can't belive I had to find this thread in order to make the module work. It'd be so easy to update it!!!

I mean, there are issues posted by people who can't use this module. And they were never answered, at least not mine.

Of course, thank you to the module's creator, but, man!!, you made me have a hard time...... geez. I guess he's working on merging this module with Imegacache Actions, but hey, let us know in the project's page.

Thanks again y'all again anyway.

adamcarsonb’s picture

adamcarsonb commented
StatusFileSize
new Patched version of imageapi.inc2.87 KB

Here's imageapi.inc with this patch applied. It worked perfectly for me, thanks a million!

jonteriele’s picture

jonteriele commented

Tnx!! patch works great for me!

osman’s picture

osman
Location Copenhagen
commented
StatusFileSize
new imagecache_effects-6.x-1.1__patched__imageapi.tar_.gz2.73 KB

I believe there is a typo in the released code and the patch, on line 176

I believe "imagedestroy" is the correct function name:

    imagedestroy($background); // line 176

Could someone verify this and commit to the head?

Until then, you can download and use the file I attached. I only updated the typo from adamcarsonb's patched attachment at #4

FYI, I checked the DEV and release codes, they all have the same typo. I can't commit the patches on my current machine. I appreciate if someone would do it actually.

Thanks,

steven jones’s picture

steven jones commented
Status: Reviewed & tested by the community » Needs work

Needs work then.

mathieu’s picture

mathieu commented
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new 401694_imagecache_effects-res_to_resource.patch4.13 KB

Here's a fixed version of the patch. Setting back to RTBC since the error was in the original version of the code (pre-patch) as well.

I tested the patch and it does fix (at least) one bug for me.