Posted by Deciphered on March 14, 2009 at 8:57am
| Project: | Imagecache Effects |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | critical |
| Assigned: | Unassigned |
| Status: | reviewed & tested by the community |
Issue Summary
The current module appears to be broken, it's referencing $image->res when it should be referencing $image->resource.
Patch attached.
| Attachment | Size |
|---|---|
| imagecache_effects-res_to_resource.patch | 4.13 KB |
Comments
#1
Yeah, this module is useless without this patch.
#2
Good find. An update would be great :)
#3
THANK YOU SIR
I can't belive I had to find this thread in order to make the module work. It'd be so easy to update it!!!
I mean, there are issues posted by people who can't use this module. And they were never answered, at least not mine.
Of course, thank you to the module's creator, but, man!!, you made me have a hard time...... geez. I guess he's working on merging this module with Imegacache Actions, but hey, let us know in the project's page.
Thanks again y'all again anyway.
#4
Here's imageapi.inc with this patch applied. It worked perfectly for me, thanks a million!
#5
Tnx!! patch works great for me!
#6
I believe there is a typo in the released code and the patch, on line 176
I believe "imagedestroy" is the correct function name:
<?phpimagedestroy($background); // line 176
?>
Could someone verify this and commit to the head?
Until then, you can download and use the file I attached. I only updated the typo from adamcarsonb's patched attachment at #4
FYI, I checked the DEV and release codes, they all have the same typo. I can't commit the patches on my current machine. I appreciate if someone would do it actually.
Thanks,
#7
Needs work then.
#8
Here's a fixed version of the patch. Setting back to RTBC since the error was in the original version of the code (pre-patch) as well.
I tested the patch and it does fix (at least) one bug for me.