new module taxonomy_image_url

promes - March 14, 2009 - 12:34
Project:Taxonomy Image
Version:5.x-1.5
Component:Code
Category:feature request
Priority:normal
Assigned:Unassigned
Status:needs review
Description

I wrote a new function extending function taxonomy_image_display().
The api function taxonomy_image_url() can get a taxonomy image for any URL within the site. I hope you will accept this small addition to the contributed modules of taxonomy image.
The only missing feature here is adding the alt="xxx" and title="xxx" whenever the default image is used at the end of this function.

AttachmentSize
taxonomy_image_url.zip2.2 KB

#1

NancyDru - March 14, 2009 - 15:26

I will consider this (even though 5.x is frozen) after you fix some problems:
* No tabs are allowed in Drupal.
* The indentation is not consistent - you have levels coming back out to the left instead of being indented more.

You might want to look at installing the Coder module.

#2

promes - March 14, 2009 - 16:40

Hello Nancy,

I am sorry I didn't think of using the coder module. I was told half a year ago this is a must before submitting a new module. But this is my first one to submit to the community.
I am on a tight schedule at this very moment, but I will come back somewhere next week.

PROMES

#3

chasz - March 17, 2009 - 11:29

+1

#4

promes - March 19, 2009 - 21:26

I used the coder module. No errors/comments are left.
I don't understand your sentence: "* The indentation is not consistent - you have levels coming back out to the left instead of being indented more.". As far as I know the intentation is correct. Maybe the tabs confused you.
I hope it confirms to the standard now and I hope a lot of people was have fun with my module.

AttachmentSize
taxonomy_image_url.zip 2.25 KB

#5

thePanz - March 19, 2009 - 22:18

@promes: in Drupal conding standard, no "tabs" (\t) are allowed, replace tabs with two spaces.

#6

promes - March 26, 2009 - 11:53

As far as I know I replaced all tabs in the second upload. The Coder module doesn't give any warnings anymore on this version.
So why this remark ThePanz? I cannot find any tab anymore ! Just use the second upload file.

#7

thePanz - March 26, 2009 - 15:37

@promes: sorry, I was replying to your question about "The indentation is not consistent".

#8

NancyDru - April 8, 2009 - 14:22
Status:active» needs review
 
 

Drupal is a registered trademark of Dries Buytaert.